You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/22 22:51:13 UTC

[GitHub] [pulsar-helm-chart] jujugrrr opened a new pull request #22: Allow to change broker service account annotations

jujugrrr opened a new pull request #22:
URL: https://github.com/apache/pulsar-helm-chart/pull/22


   ### Motivation
   
   We need to be able to change annotation to inject AWS IAM role (EKS based deployment).
   https://docs.aws.amazon.com/eks/latest/userguide/specify-service-account-role.html
   
   With 2.6.0 and this annotation change we were able to use Tiered Storage with S3 and EKS/IAM(OIDC).
   
   e.g : 
   ```
     annotations:
       eks.amazonaws.com/role-arn: arn:aws:iam::66666:role/my-iam-role-with-s3-access
   ```
   values.yaml
   ```
   broker:
     service_account:
       annotations:
         eks.amazonaws.com/role-arn: arn:aws:iam::66666:role/my-iam-role-with-s3-access
   ```
   ### Modifications
   
   Added a value to allow to change annotations fro broker service account.
   I've tried following style from other part of the code.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] sijie merged pull request #22: Allow to change broker service account annotations

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #22:
URL: https://github.com/apache/pulsar-helm-chart/pull/22


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] jujugrrr commented on pull request #22: Allow to change broker service account annotations

Posted by GitBox <gi...@apache.org>.
jujugrrr commented on pull request #22:
URL: https://github.com/apache/pulsar-helm-chart/pull/22#issuecomment-647987680


   Thanks @sijie 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org