You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/09/10 19:36:38 UTC
[jira] Created: (SANSELAN-42) IPTCConstants: final arrays are not
immutable
IPTCConstants: final arrays are not immutable
---------------------------------------------
Key: SANSELAN-42
URL: https://issues.apache.org/jira/browse/SANSELAN-42
Project: Commons Sanselan
Issue Type: Bug
Reporter: Sebb
formats.jpeg.iptc.IPTCConstants contains the following public static final arrays:
IPTC_PREFIX
IPTC_TYPES
Array element are not immutable, even if the array itself is, so the entries could potentially be corrupted accidentally or deliberately.
IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not, it could be made private and a getter added.
IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be moved there and made private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SANSELAN-42) IPTCConstants: final arrays are not
immutable
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANSELAN-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908115#action_12908115 ]
Sebb commented on SANSELAN-42:
------------------------------
Other unsafe arrays are:
formats.jpeg.JpegConstants.EOI, SOI, MARKERS etc (many in that class)
formats.jpeg.JpegImageParser.AcceptedExtensions
formats.png.PngConstants.PNG_Signature
formats.png.ScanExpediterInterlaced.Starting_Row etc.
formats.tiff.constants.AllTagConstants.ALL_TAGS
formats.tiff.constants.TiffFieldTypeConstants.FIELD_TYPES
formats.tiff.constants.TiffFieldTypeConstants.FIELD_TYPE_ANY et.c
formats.tiff.constants.TiffTagConstants.ALL_TIFF_TAGS
icc.IccConstants.IccTagDataTypes
> IPTCConstants: final arrays are not immutable
> ---------------------------------------------
>
> Key: SANSELAN-42
> URL: https://issues.apache.org/jira/browse/SANSELAN-42
> Project: Commons Sanselan
> Issue Type: Bug
> Reporter: Sebb
>
> formats.jpeg.iptc.IPTCConstants contains the following public static final arrays:
> IPTC_PREFIX
> IPTC_TYPES
> Array element are not immutable, even if the array itself is, so the entries could potentially be corrupted accidentally or deliberately.
> IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not, it could be made private and a getter added.
> IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be moved there and made private.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.