You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/27 19:47:07 UTC
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #623: [YUNIKORN-1826] Convert shim to use scoped logging
codecov[bot] commented on PR #623:
URL: https://github.com/apache/yunikorn-k8shim/pull/623#issuecomment-1610118273
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#623](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8e472ce) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/ec48765692e5abdb20c4dc29033b10799f3f62ca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ec48765) will **decrease** coverage by `0.05%`.
> The diff coverage is `50.63%`.
```diff
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 70.88% 70.83% -0.05%
==========================================
Files 49 49
Lines 8115 8115
==========================================
- Hits 5752 5748 -4
- Misses 2153 2157 +4
Partials 210 210
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/admission/informers.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9pbmZvcm1lcnMuZ28=) | `89.47% <0.00%> (ø)` | |
| [pkg/admission/namespace\_cache.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9uYW1lc3BhY2VfY2FjaGUuZ28=) | `85.71% <0.00%> (ø)` | |
| [pkg/admission/pki/certs.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9wa2kvY2VydHMuZ28=) | `65.21% <0.00%> (ø)` | |
| [pkg/admission/priority\_class\_cache.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9wcmlvcml0eV9jbGFzc19jYWNoZS5nbw==) | `81.66% <0.00%> (ø)` | |
| [pkg/admission/util.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi91dGlsLmdv) | `96.15% <0.00%> (ø)` | |
| [pkg/plugin/support/framework\_handle.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3BsdWdpbi9zdXBwb3J0L2ZyYW1ld29ya19oYW5kbGUuZ28=) | `22.03% <0.00%> (ø)` | |
| [pkg/cache/application\_state.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX3N0YXRlLmdv) | `90.18% <20.00%> (ø)` | |
| [pkg/appmgmt/appmgmt.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `49.35% <33.33%> (ø)` | |
| [pkg/cache/task\_state.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NhY2hlL3Rhc2tfc3RhdGUuZ28=) | `71.95% <33.33%> (ø)` | |
| [pkg/plugin/predicates/predicate\_manager.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY2F0ZV9tYW5hZ2VyLmdv) | `51.42% <34.78%> (ø)` | |
| ... and [29 more](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/623?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org