[GitHub] [shardingsphere-elasticjob] xlcn commented on a diff in pull request #2123: fix leader nullpointexception and increament listener core pool size

[GitBox <gi...@apache.org>]

xlcn commented on code in PR #2123:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2123#discussion_r961283377


##########
elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/listener/ListenerNotifierManager.java:
##########
@@ -63,7 +63,8 @@ public void registerJobNotifyExecutor(final String jobName) {
             synchronized (this) {
                 if (!listenerNotifyExecutors.containsKey(jobName)) {
                     ThreadFactory threadFactory = ThreadUtils.newGenericThreadFactory("ListenerNotify-" + jobName);
-                    ExecutorService notifyExecutor = Executors.newSingleThreadExecutor(threadFactory);
+                    // Use unbounded thread pool to cover all the listeners to execute event, avoid zk watch loss.

Review Comment:
   okay



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org