You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/08 15:46:13 UTC
[GitHub] [incubator-dolphinscheduler] whw02 opened a new pull request #4745: Update ZKMasterClient.java
whw02 opened a new pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745
## *Tips*
- *Thanks very much for contributing to Apache DolphinScheduler.*
- *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds checkstyle plugin.)*
## Brief change log
*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #4745: Update ZKMasterClient.java
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #4745: Update ZKMasterClient.java
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745#issuecomment-783952836
@whw02 , thanks for your first contribution, please contact me(wechat: 510570367 or mail : lidongdai@apache.org), I think I can help you if you need any help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on pull request #4745: Update ZKMasterClient.java
Posted by GitBox <gi...@apache.org>.
dailidong commented on pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745#issuecomment-787462478
> thanks,this debug(#4757) is closed.
> […](#)
@whw02 , thanks for again, though this pr is not been merged into dev, I think maybe next time, I'm still looking forward to your participation, please contact me(wechat: 510570367 or mail : lidongdai@apache.org), I want to make friends with you, when added, please tell me your github id, thx
By the way , the issue has been solved, I will close this PR
remember contact me, ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] whw02 commented on pull request #4745: Update ZKMasterClient.java
Posted by GitBox <gi...@apache.org>.
whw02 commented on pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745#issuecomment-787459989
thanks,this debug(#4757) is closed.
------------------ 原始邮件 ------------------
发件人: "dailidong"<notifications@github.com>;
发送时间: 2021年2月23日(星期二) 下午2:50
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "王汉文"<1029312668@qq.com>; "Mention"<mention@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] Update ZKMasterClient.java (#4745)
@whw02 , thanks for your first contribution, please contact me(wechat: 510570367 or mail : lidongdai@apache.org), I think I can help you if you need any help
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] chengshiwen commented on pull request #4745: Update ZKMasterClient.java
Posted by GitBox <gi...@apache.org>.
chengshiwen commented on pull request #4745:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4745#issuecomment-775250855
@whw02 Please review [pull-request](https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html) and rename the title, and pass the **Backend / Compile-chec**k and **Unit Test / Check code style**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org