You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org> on 2010/03/16 21:52:27 UTC

[jira] Created: (HARMONY-6476) [jdktools] Implement the serialver command line tool

 [jdktools] Implement the serialver command line tool
-----------------------------------------------------

                 Key: HARMONY-6476
                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
             Project: Harmony
          Issue Type: Task
          Components: JDK
            Reporter: Marcos Paulino Roriz Junior
            Priority: Minor


Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858770#action_12858770 ] 

Oliver Deakin commented on HARMONY-6476:
----------------------------------------

Thanks Marcos - great to hear you will have a patch for the -show option too. Is the Harmony screenshot screenshot1.png? It does look a little different to the RI - does it work ok even though the display is different? There is still a little work to be done in the area of swing for Harmony, but as long as your tool works and displays ok (it does not need to be identical to the RI) then that will be fine.

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior updated HARMONY-6476:
-------------------------------------------------

    Attachment:     (was: showGUI.patch)

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin resolved HARMONY-6476.
------------------------------------

    Fix Version/s: 6.0M2
                   5.0M14
       Resolution: Fixed

Thanks Marcos! I have applied the patch at repo revision r936264 - please check that it was applied as expected and close this defect if you are happy it is resolved.

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>             Fix For: 6.0M2, 5.0M14
>
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch, showGUI.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior closed HARMONY-6476.
------------------------------------------------


Thanks Oliver, it's resolved :)

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>             Fix For: 6.0M2, 5.0M14
>
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch, showGUI.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858457#action_12858457 ] 

Oliver Deakin commented on HARMONY-6476:
----------------------------------------

Thanks Marcos - I have applied your patch at repo revision r935528. I made some slight modifications - adding Apache license headers to the test files and also moving the test cases from org.apache.harmony.tests.tool.serialver to org.apache.harmony.tests.tools.serialver package so they were alongside existing tests. I also added a line to the samsa\build.xml to create the serialver executable. Please can you check you are happy with the modifications I have made and that the tool works as expected? Also, have you had any luck progressing with the -show option?

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior updated HARMONY-6476:
-------------------------------------------------

    Attachment: showGUI.patch

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch, showGUI.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849955#action_12849955 ] 

Marcos Paulino Roriz Junior commented on HARMONY-6476:
------------------------------------------------------

Mark, can I implement -show with swing rather than awt?
Right know sun impl has some bugs, for example it won't close the window. I think they didn't and a handler there. Anyway can I also fix this bug and do on swing?/?

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Mark Hindess
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oliver Deakin reassigned HARMONY-6476:
--------------------------------------

    Assignee: Oliver Deakin  (was: Mark Hindess)

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess reassigned HARMONY-6476:
-------------------------------------

    Assignee: Mark Hindess

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Mark Hindess
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior updated HARMONY-6476:
-------------------------------------------------

    Attachment: serialver.patch

Patch

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess reopened HARMONY-6476:
-----------------------------------


We generally mark issues "Patch Available" and leave them open.  The committer will resolve it when they make the commit to SVN and then ask you to confirm that it has been applied correctly by closing the issue.


>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior updated HARMONY-6476:
-------------------------------------------------

    Attachment: screenshot1.png
                screenshot2.png

Thanks Oliver,
The patch is perfect.
I forgot to submit the -show part. I'll be sending already!! But before sending I want to question something... I'm getting a strange window display when using the JFrame on Harmony, it's kinda strange it's seems theres a problem when running swing. I've attached a screenshot for more info. RI also attached.

Thanks in advance,
Marcos

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior resolved HARMONY-6476.
--------------------------------------------------

    Resolution: Fixed

Implemented almost 100% of the tool, only need the -show option. Which I'll be adding later.

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Priority: Minor
>         Attachments: serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-6476) [jdktools] Implement the serialver command line tool

Posted by "Marcos Paulino Roriz Junior (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcos Paulino Roriz Junior updated HARMONY-6476:
-------------------------------------------------

    Attachment: showGUI.patch

Yeah, the screen1 is from Harmony :3.
The tool works flawless. Only prob is the swing part, but it doensn't interfere with the functionality.

The patch is attached. :)

>  [jdktools] Implement the serialver command line tool
> -----------------------------------------------------
>
>                 Key: HARMONY-6476
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6476
>             Project: Harmony
>          Issue Type: Task
>          Components: JDK
>            Reporter: Marcos Paulino Roriz Junior
>            Assignee: Oliver Deakin
>            Priority: Minor
>         Attachments: screenshot1.png, screenshot2.png, serialver.patch
>
>
> Implement the serialver tool, which is a tool to generate serialversionUID values to Serializable classes. This field is used to apply "compatiblity", with the class being (de/se)rialized.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.