You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/02/08 03:16:47 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1211: [CELEBORN-239][FOLLOWUP] PUSH_DATA_TIMEOUT_MASTER/SLAVE should support convert through RPC
AngersZhuuuu opened a new pull request, #1211:
URL: https://github.com/apache/incubator-celeborn/pull/1211
### What changes were proposed in this pull request?
PUSH_DATA_TIMEOUT_MASTER/SLAVE should support convert through RPC， without this LifecycleManager side will revive null status code, now is
```
Received Revive request, local-1675825716934, 0, 3, 0, ,1, 0, PartitionLocation[
id(rawId-attemptId)-epoch:1(1-0)-0
host-rpcPort-pushPort-fetchPort-replicatePort:10.53.37.111-53650-53651-53653-53652
mode:MASTER
peer:(empty)
storage hint:StorageInfo{type=MEMORY, mountPoint='/', finalResult=false, filePath=}
mapIdBitMap:null], StatusCode{value=PUSH_DATA_TIMEOUT_MASTER}.
Received Revive request, local-1675825729662, 0, 2, 0, ,0, 0, PartitionLocation[
id(rawId-attemptId)-epoch:0(0-0)-0
host-rpcPort-pushPort-fetchPort-replicatePort:10.53.37.111-53650-53651-53653-53652
mode:MASTER
peer:(host-rpcPort-pushPort-fetchPort-replicatePort:10.53.37.111-53654-53655-53657-53656)
storage hint:StorageInfo{type=MEMORY, mountPoint='/', finalResult=false, filePath=}
mapIdBitMap:null], StatusCode{value=PUSH_DATA_TIMEOUT_SLAVE}.
```
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1211: [CELEBORN-239][FOLLOWUP] PUSH_DATA_TIMEOUT_MASTER/SLAVE should support convert through RPC
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1211:
URL: https://github.com/apache/incubator-celeborn/pull/1211#issuecomment-1421938949
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1211](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ee3e150) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/ae32c702b6e9922f75bc7ce14ac1d79293b0ab70?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae32c70) will **increase** coverage by `0.74%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1211 +/- ##
============================================
+ Coverage 26.42% 27.15% +0.74%
- Complexity 758 802 +44
============================================
Files 206 212 +6
Lines 17595 17972 +377
Branches 1930 1963 +33
============================================
+ Hits 4648 4879 +231
- Misses 12629 12766 +137
- Partials 318 327 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../scala/org/apache/celeborn/common/util/Utils.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3V0aWwvVXRpbHMuc2NhbGE=) | `6.92% <0.00%> (-0.02%)` | :arrow_down: |
| [...va/org/apache/celeborn/common/write/PushState.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vd3JpdGUvUHVzaFN0YXRlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/celeborn/service/deploy/worker/Worker.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../celeborn/common/write/InFlightRequestTracker.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vd3JpdGUvSW5GbGlnaHRSZXF1ZXN0VHJhY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../celeborn/service/deploy/worker/WorkerSource.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1dvcmtlclNvdXJjZS5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
| [...leborn/service/deploy/worker/PushDataHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL1B1c2hEYXRhSGFuZGxlci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...rn/common/network/server/memory/MemoryManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvbWVtb3J5L01lbW9yeU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../deploy/worker/congestcontrol/BufferStatusHub.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvY29uZ2VzdGNvbnRyb2wvQnVmZmVyU3RhdHVzSHViLmphdmE=) | `78.95% <0.00%> (ø)` | |
| [...e/deploy/worker/congestcontrol/TimeSlidingHub.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS93b3JrZXIvY29uZ2VzdGNvbnRyb2wvVGltZVNsaWRpbmdIdWIuamF2YQ==) | `71.70% <0.00%> (ø)` | |
| [...org/apache/celeborn/common/write/PushStrategy.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vd3JpdGUvUHVzaFN0cmF0ZWd5LmphdmE=) | `62.50% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-celeborn/pull/1211?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1211: [CELEBORN-239][FOLLOWUP] PUSH_DATA_TIMEOUT_MASTER/SLAVE should support convert through RPC
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1211:
URL: https://github.com/apache/incubator-celeborn/pull/1211#issuecomment-1421926508
ping @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1211: [CELEBORN-239][FOLLOWUP] PUSH_DATA_TIMEOUT_MASTER/SLAVE should support convert through RPC
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1211:
URL: https://github.com/apache/incubator-celeborn/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org