You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by we...@apache.org on 2016/03/08 23:32:43 UTC
reef git commit: [REEF-552] Make MessagingTransportFactory
constructor private
Repository: reef
Updated Branches:
refs/heads/master db685c756 -> 0318bcbed
[REEF-552] Make MessagingTransportFactory constructor private
This change does the last item on the original list: converting
MessagingTransportFactory constructor to private.
JIRA:
[REEF-552](https://issues.apache.org/jira/browse/REEF-552)
Pull request:
This closes #881
Project: http://git-wip-us.apache.org/repos/asf/reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/reef/commit/0318bcbe
Tree: http://git-wip-us.apache.org/repos/asf/reef/tree/0318bcbe
Diff: http://git-wip-us.apache.org/repos/asf/reef/diff/0318bcbe
Branch: refs/heads/master
Commit: 0318bcbed7258836c141d96ddef86ad1990a0cab
Parents: db685c7
Author: Mariia Mykhailova <ma...@apache.org>
Authored: Tue Mar 8 11:29:40 2016 -0800
Committer: Markus Weimer <we...@apache.org>
Committed: Tue Mar 8 14:32:00 2016 -0800
----------------------------------------------------------------------
.../remote/transport/netty/MessagingTransportFactory.java | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/reef/blob/0318bcbe/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
index 0409553..2f0d84d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/MessagingTransportFactory.java
@@ -36,17 +36,12 @@ import javax.inject.Inject;
/**
* Factory that creates a messaging transport.
*/
-public class MessagingTransportFactory implements TransportFactory {
+public final class MessagingTransportFactory implements TransportFactory {
private final String localAddress;
- /**
- * @deprecated Have an instance injected instead.
- */
- @Deprecated
@Inject
- // TODO[JIRA REEF-703]: change constructor to private
- public MessagingTransportFactory(final LocalAddressProvider localAddressProvider) {
+ private MessagingTransportFactory(final LocalAddressProvider localAddressProvider) {
this.localAddress = localAddressProvider.getLocalAddress();
}