You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2006/03/13 23:48:38 UTC

[jira] Created: (HADOOP-78) rpc commands not buffered

rpc commands not buffered
-------------------------

         Key: HADOOP-78
         URL: http://issues.apache.org/jira/browse/HADOOP-78
     Project: Hadoop
        Type: Bug
  Components: ipc  
    Versions: 0.1    
    Reporter: Owen O'Malley
 Assigned to: Owen O'Malley 
     Fix For: 0.1


Calls using Hadoop's RPC framework get sent across the network byte by byte.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (HADOOP-78) rpc commands not buffered

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-78?page=all ]

Owen O'Malley updated HADOOP-78:
--------------------------------

    Attachment: rpc-buffer.patch

The problem is that the Connection object was doing:

out = new BufferedOutputStream(new FilteredOutputStream(sock.getOutputStream()) { 
// definition of write(byte[], int offset, int length)
});

The problem is that the write definition called super.write(byte[], int, int), which did a loop calling write(byte) for each byte. So I changed the definition to call out.write(byte[], int,int), which will send the array in a single call.

> rpc commands not buffered
> -------------------------
>
>          Key: HADOOP-78
>          URL: http://issues.apache.org/jira/browse/HADOOP-78
>      Project: Hadoop
>         Type: Bug
>   Components: ipc
>     Versions: 0.1
>     Reporter: Owen O'Malley
>     Assignee: Owen O'Malley
>      Fix For: 0.1
>  Attachments: rpc-buffer.patch
>
> Calls using Hadoop's RPC framework get sent across the network byte by byte.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (HADOOP-78) rpc commands not buffered

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HADOOP-78?page=all ]
     
Doug Cutting resolved HADOOP-78:
--------------------------------

    Resolution: Fixed

Thanks for catching this, Owen!  This can make a big performance difference!

> rpc commands not buffered
> -------------------------
>
>          Key: HADOOP-78
>          URL: http://issues.apache.org/jira/browse/HADOOP-78
>      Project: Hadoop
>         Type: Bug
>   Components: ipc
>     Versions: 0.1
>     Reporter: Owen O'Malley
>     Assignee: Owen O'Malley
>      Fix For: 0.1
>  Attachments: rpc-buffer.patch
>
> Calls using Hadoop's RPC framework get sent across the network byte by byte.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira