[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #2242: Draft implementing sort-merge join

[GitBox <gi...@apache.org>]

yjshen commented on code in PR #2242:
URL: https://github.com/apache/arrow-datafusion/pull/2242#discussion_r851361782


##########
datafusion/core/src/physical_plan/mod.rs:
##########
@@ -217,8 +218,9 @@ pub trait ExecutionPlan: Debug + Send + Sync {
     fn children(&self) -> Vec<Arc<dyn ExecutionPlan>>;
 
     /// Returns a new plan where all children were replaced by new plans.
+    /// The size of `children` must be equal to the size of `ExecutionPlan::children()`.

Review Comment:
   ```suggestion
       /// Returns a new plan where all children were replaced by new plans.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org