You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/20 11:09:45 UTC
[GitHub] zeppelin pull request #2267: [MINOR] Verbose logging in zeppelin-web
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2267
[MINOR] Verbose logging in zeppelin-web
### What is this PR for?
Verbose logging in zeppelin-web. See the screenshot below.
- Remove the first `console.log` since it's already printed in the following statement.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
MINOR
### How should this be tested?
1. start Zeppelin in dev mode (`:9000`)
2. open browser console
### Screenshots (if appropriate)
#### Before
<img width="841" alt="screen shot 2017-04-20 at 7 12 18 pm" src="https://cloud.githubusercontent.com/assets/4968473/25227897/352e49a8-2605-11e7-98dc-58c3810e1971.png">
#### After
<img width="810" alt="screen shot 2017-04-20 at 8 06 51 pm" src="https://cloud.githubusercontent.com/assets/4968473/25227904/37be8db8-2605-11e7-84cb-bc981d85d04d.png">
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin MINOR/verbose-logging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2267
----
commit 7448e52ddcb76443f60c37961da503a719923cb2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-20T11:05:10Z
fix: Use console.log with JSON.parse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2267: [MINOR] Verbose logging in zeppelin-web
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2267
[MINOR] Verbose logging in zeppelin-web
### What is this PR for?
Verbose logging in zeppelin-web. See the screenshot below.
- Remove the first `console.log` since it's already printed in the following statement.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
MINOR
### How should this be tested?
1. start Zeppelin in dev mode (`:9000`)
2. open browser console
### Screenshots (if appropriate)
#### Before
<img width="841" alt="screen shot 2017-04-20 at 7 12 18 pm" src="https://cloud.githubusercontent.com/assets/4968473/25227897/352e49a8-2605-11e7-98dc-58c3810e1971.png">
#### After
<img width="810" alt="screen shot 2017-04-20 at 8 06 51 pm" src="https://cloud.githubusercontent.com/assets/4968473/25227904/37be8db8-2605-11e7-84cb-bc981d85d04d.png">
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin MINOR/verbose-logging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2267
----
commit 7448e52ddcb76443f60c37961da503a719923cb2
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-20T11:05:10Z
fix: Use console.log with JSON.parse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2267
@1ambda `event.data` is useful for me to see what is in the json data. Could we keep that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2267: [ZEPPELIN-2435](WIP) Add logging level facility...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2267
@zjffdu you can expand it in browser console by clicking it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2267
@1ambda What I want to see is plain text json. But the expanded object seems not plain text, it contains fields `__proto__`. Make sense to add logging level, but not sure how to add that, I am not expert of front end, could you help add that ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2267: [MINOR] Verbose logging in zeppelin-web
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [ZEPPELIN-2435](WIP) Add logging level facility to fro...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2267
created issue https://issues.apache.org/jira/browse/ZEPPELIN-2435
Let me work it on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2267
LGTM and merge to master if no further comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [MINOR] Verbose logging in zeppelin-web
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2267
Or do you want to see the details without click? Then, we need something like logging level in frontend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [ZEPPELIN-2435](WIP) Add logging level facility to fro...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2267
@1ambda Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2267: [ZEPPELIN-2435](WIP) Add logging level facility to fro...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2267
It's better to use `console.debug`, ... and so on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---