You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2017/07/08 00:22:27 UTC

Review Request 60723: Made intialization for `__address__` consistent.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60723/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7769
    https://issues.apache.org/jira/browse/MESOS-7769


Repository: mesos


Description
-------

Made intialization for `__address__` consistent.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 97f737b0b7be23df32f2863d4d6891ec2518529e 


Diff: https://reviews.apache.org/r/60723/diff/1/


Testing
-------

sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
tcp        0      0 10.0.2.15:5059          0.0.0.0:*               LISTEN

sudo ./build/bin/mesos-agent.sh  --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
tcp        0      0 0.0.0.0:5059            0.0.0.0:*               LISTEN

sudo ./build/bin/mesos-agent.sh  --master=10.0.2.15:5050 --work_dir=/tmp/mesos
tcp        0      0 0.0.0.0:5051            0.0.0.0:*               LISTEN

sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --master=10.0.2.15:5050 --work_dir=/tmp/meso
tcp        0      0 10.0.2.15:5051          0.0.0.0:*               LISTEN


Thanks,

Avinash sridharan

Re: Review Request 60723: Made intialization for `__address__` consistent.

Posted by Jiang Yan Xu <ya...@jxu.me>.

> On July 10, 2017, 9:15 a.m., Jiang Yan Xu wrote:
> > Ship It!

I still found it a bit odd that initialization of `__address__` is both above and below `__address6__` but the initialization of `__address__` is way more complex than that of `__address6__` at this point and it's intertwined with socket initialization. Perhaps worth refactoring in the future.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60723/#review180045
-----------------------------------------------------------


On July 7, 2017, 5:22 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60723/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 5:22 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7769
>     https://issues.apache.org/jira/browse/MESOS-7769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made intialization for `__address__` consistent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 97f737b0b7be23df32f2863d4d6891ec2518529e 
> 
> 
> Diff: https://reviews.apache.org/r/60723/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 10.0.2.15:5059          0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 0.0.0.0:5059            0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 0.0.0.0:5051            0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --master=10.0.2.15:5050 --work_dir=/tmp/meso
> tcp        0      0 10.0.2.15:5051          0.0.0.0:*               LISTEN
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 60723: Made intialization for `__address__` consistent.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60723/#review180045
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On July 7, 2017, 5:22 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60723/
> -----------------------------------------------------------
> 
> (Updated July 7, 2017, 5:22 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7769
>     https://issues.apache.org/jira/browse/MESOS-7769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made intialization for `__address__` consistent.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 97f737b0b7be23df32f2863d4d6891ec2518529e 
> 
> 
> Diff: https://reviews.apache.org/r/60723/diff/1/
> 
> 
> Testing
> -------
> 
> sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 10.0.2.15:5059          0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --port=5059 --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 0.0.0.0:5059            0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --master=10.0.2.15:5050 --work_dir=/tmp/mesos
> tcp        0      0 0.0.0.0:5051            0.0.0.0:*               LISTEN
> 
> sudo ./build/bin/mesos-agent.sh  --ip=10.0.2.15 --master=10.0.2.15:5050 --work_dir=/tmp/meso
> tcp        0      0 10.0.2.15:5051          0.0.0.0:*               LISTEN
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>