You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/27 00:01:01 UTC
Re: Review Request 42820: Relaxed the logrotate ContainerLogger's
--logrotate_path validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 3:01 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
Relax the check on `--logrotate_path` and changed to an Option.
Summary (updated)
-----------------
Relaxed the logrotate ContainerLogger's --logrotate_path validation.
Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515
Repository: mesos
Description (updated)
-------
The `logrotate --version` flag is actually a very recent addition (3.9.1). As such, most `logrotate` binaries may not have the flag.
Changed the `--logrotate_path` validation to take an Option instead.
If specified, checks if the path is absolute and that it is executable.
If not specified, checks if logrotate exists.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02
src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f
src/slave/container_loggers/logrotate.cpp 7d36c052ff7a180b45ca265fb7ff4c6900d98d64
Diff: https://reviews.apache.org/r/42820/diff/
Testing (updated)
-------
make check (OSX & Centos6.7 & Centos7)
Thanks,
Joseph Wu
Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/#review116484
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 26, 2016, 11:45 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42820/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 11:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
>
>
> Bugs: MESOS-4515
> https://issues.apache.org/jira/browse/MESOS-4515
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `logrotate --version` flag is actually a very recent addition (3.9.1).
> The `--help` flag is more likely to be present on a supported system-with-logrotate, given logrotate's usage of popopt.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02
> src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f
>
> Diff: https://reviews.apache.org/r/42820/diff/
>
>
> Testing
> -------
>
> make check (OSX & Centos6.7 & Centos7)
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 3:45 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till Toenshoff.
Changes
-------
Changed back to the --help version (diff #1).
Summary (updated)
-----------------
Fixed logrotate ContainerLogger on Centos6.
Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515
Repository: mesos
Description (updated)
-------
The `logrotate --version` flag is actually a very recent addition (3.9.1).
The `--help` flag is more likely to be present on a supported system-with-logrotate, given logrotate's usage of popopt.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.hpp 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02
src/slave/container_loggers/logrotate.hpp fd9c071bbd4c07ad8728c63c42fd63c0bba2573f
Diff: https://reviews.apache.org/r/42820/diff/
Testing
-------
make check (OSX & Centos6.7 & Centos7)
Thanks,
Joseph Wu