You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ea...@apache.org on 2019/03/19 14:16:09 UTC

[qpid-dispatch] branch master updated (1a83f99 -> 8996ce4)

This is an automated email from the ASF dual-hosted git repository.

eallen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git.


    from 1a83f99  DISPATCH-1291 Show link settlement rate and delayed deliveries
     new 2f3402f  Calculate rate for chord diagram over 5 seconds to match link settlement rate calculations
     new 8996ce4  Remove extraneous logging statements

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 console/stand-alone/plugin/js/chord/data.js  | 33 ++++++++++++++--------------
 console/stand-alone/plugin/js/qdrOverview.js |  2 --
 2 files changed, 17 insertions(+), 18 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[qpid-dispatch] 02/02: Remove extraneous logging statements

Posted by ea...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

eallen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git

commit 8996ce45a2ac759f6753f374477054bb71e6e31e
Author: Ernest Allen <ea...@redhat.com>
AuthorDate: Tue Mar 19 10:15:49 2019 -0400

    Remove extraneous logging statements
---
 console/stand-alone/plugin/js/qdrOverview.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/console/stand-alone/plugin/js/qdrOverview.js b/console/stand-alone/plugin/js/qdrOverview.js
index c0a1462..11bebd5 100644
--- a/console/stand-alone/plugin/js/qdrOverview.js
+++ b/console/stand-alone/plugin/js/qdrOverview.js
@@ -735,8 +735,6 @@ export class OverviewController {
               });
             }
           });
-        console.log('linkFields:');
-        console.log(linkFields);
         if (expected === ++received) {
           linkFields.sort(function (a, b) { return a.link < b.link ? -1 : a.link > b.link ? 1 : 0; });
           completionCallbacks.forEach(function (cb) {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org


[qpid-dispatch] 01/02: Calculate rate for chord diagram over 5 seconds to match link settlement rate calculations

Posted by ea...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

eallen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git

commit 2f3402f87319234eaf5df3dfab7b635ed294c069
Author: Ernest Allen <ea...@redhat.com>
AuthorDate: Tue Mar 19 10:15:23 2019 -0400

    Calculate rate for chord diagram over 5 seconds to match link settlement rate calculations
---
 console/stand-alone/plugin/js/chord/data.js | 33 +++++++++++++++--------------
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/console/stand-alone/plugin/js/chord/data.js b/console/stand-alone/plugin/js/chord/data.js
index c1cd978..88b7e9d 100644
--- a/console/stand-alone/plugin/js/chord/data.js
+++ b/console/stand-alone/plugin/js/chord/data.js
@@ -20,7 +20,7 @@ under the License.
 /* global angular Promise */
 import { MIN_CHORD_THRESHOLD } from './matrix.js';
 
-const SAMPLES = 3; // number of snapshots to use for rate calculations
+const SAMPLES = 5; // number of snapshots to use for rate calculations
 
 class ChordData { // eslint-disable-line no-unused-vars
   constructor(QDRService, isRate, converter) {
@@ -114,11 +114,11 @@ class ChordData { // eslint-disable-line no-unused-vars
           for (let i = 0; routerLinks && (i < routerLinks.results.length); i++) {
             let link = self.QDRService.utilities.flatten(routerLinks.attributeNames, routerLinks.results[i]);
             // if the link is an outbound/enpoint/non console
-            if (link.linkType === 'endpoint' && 
-                link.linkDir === 'out' && 
-                (link.owningAddr && 
-                 !link.owningAddr.startsWith('Ltemp.') &&
-                 !link.owningAddr.startsWith('M0$'))) {
+            if (link.linkType === 'endpoint' &&
+              link.linkDir === 'out' &&
+              (link.owningAddr &&
+                !link.owningAddr.startsWith('Ltemp.') &&
+                !link.owningAddr.startsWith('M0$'))) {
               // keep track of the raw egress values as well as their ingress and egress routers and the address
               for (let j = 0; j < ingressRouters.length; j++) {
                 let messages = link.ingressHistogram ? link.ingressHistogram[j] : 0;
@@ -163,10 +163,10 @@ let calcRate = function (values, last_values, snapshots) {
 
   // ensure the snapshots are initialized
   if (snapshots.length < SAMPLES) {
-    for (let i=0; i<SAMPLES; i++) {
-      if (snapshots.length < i+1) {
+    for (let i = 0; i < SAMPLES; i++) {
+      if (snapshots.length < i + 1) {
         snapshots[i] = angular.copy(last_values);
-        snapshots[i].timestamp = now - (1000 * (SAMPLES-i));
+        snapshots[i].timestamp = now - (1000 * (SAMPLES - i));
       }
     }
   }
@@ -176,24 +176,25 @@ let calcRate = function (values, last_values, snapshots) {
   snapshots.push(angular.copy(last_values));
 
   let oldest = snapshots[0];
-  let newest = snapshots[snapshots.length-1];
+  let newest = snapshots[snapshots.length - 1];
   let rateValues = [];
   let elapsed = (newest.timestamp - oldest.timestamp) / 1000;
   let getValueFor = function (snap, value) {
-    for (let i=0; i<snap.values.length; i++) {
+    for (let i = 0; i < snap.values.length; i++) {
       if (snap.values[i].ingress === value.ingress &&
         snap.values[i].egress === value.egress &&
         snap.values[i].address === value.address)
         return snap.values[i].messages;
     }
   };
-  values.forEach( function (value) {
+  values.forEach(function (value) {
     let first = getValueFor(oldest, value);
     let last = getValueFor(newest, value);
     let rate = (last - first) / elapsed;
 
-    rateValues.push({ingress: value.ingress, 
-      egress: value.egress, 
+    rateValues.push({
+      ingress: value.ingress,
+      egress: value.egress,
       address: value.address,
       messages: Math.max(rate, MIN_CHORD_THRESHOLD)
     });
@@ -202,12 +203,12 @@ let calcRate = function (values, last_values, snapshots) {
 };
 
 let genKeys = function (values) {
-  values.forEach( function (value) {
+  values.forEach(function (value) {
     value.key = value.egress + value.ingress + value.address;
   });
 };
 let sortByKeys = function (values) {
-  return values.sort( function (a, b) {
+  return values.sort(function (a, b) {
     return a.key > b.key ? 1 : a.key < b.key ? -1 : 0;
   });
 };


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org