You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/05/25 16:10:21 UTC

Review Request 59577: RANGER-1616 - Upgrade to Mockito 2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59577/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1616
    https://issues.apache.org/jira/browse/RANGER-1616


Repository: ranger


Description
-------

This task is to upgrade the mockito testing framework to mockito 2. Mockito 2 works with Java 9 and it also enforces that the test-code is kept tidy by making sure that unused mocks aren't allowed.


Diffs
-----

  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java 713c5885 
  plugin-nifi/pom.xml 3873fc41 
  pom.xml 35c85866 
  security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java fdf4dae0 
  security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java eb2f417d 
  security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 0bd39e09 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java d75ba675 
  security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java f83f069c 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 48a910d9 
  security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 9faae937 
  security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 94892745 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 9f4acc60 
  security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java e2692835 
  security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java fc9cdd90 
  security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 8a90ac85 
  security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java f244b477 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java ff40a198 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java b10d2fda 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyServiceBase.java 803a0cb4 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java 56109d86 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java 15857cb5 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceService.java f6b02a84 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceServiceBase.java 54fee7de 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java 2ca0fd2f 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java 15fd5036 


Diff: https://reviews.apache.org/r/59577/diff/1/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 59577: RANGER-1616 - Upgrade to Mockito 2

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59577/#review177276
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On 五月 25, 2017, 4:10 p.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59577/
> -----------------------------------------------------------
> 
> (Updated 五月 25, 2017, 4:10 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1616
>     https://issues.apache.org/jira/browse/RANGER-1616
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to upgrade the mockito testing framework to mockito 2. Mockito 2 works with Java 9 and it also enforces that the test-code is kept tidy by making sure that unused mocks aren't allowed.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerPolicyValidator.java 713c5885 
>   plugin-nifi/pom.xml 3873fc41 
>   pom.xml 35c85866 
>   security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java fdf4dae0 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java eb2f417d 
>   security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 0bd39e09 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java d75ba675 
>   security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java f83f069c 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 48a910d9 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java 9faae937 
>   security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java 94892745 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 9f4acc60 
>   security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java e2692835 
>   security-admin/src/test/java/org/apache/ranger/rest/TestUserREST.java fc9cdd90 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java 8a90ac85 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXKeyREST.java f244b477 
>   security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java ff40a198 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyService.java b10d2fda 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerPolicyServiceBase.java 803a0cb4 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java 56109d86 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefServiceBase.java 15857cb5 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceService.java f6b02a84 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceServiceBase.java 54fee7de 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefService.java 2ca0fd2f 
>   security-admin/src/test/java/org/apache/ranger/service/TestRangerTagDefServiceBase.java 15fd5036 
> 
> 
> Diff: https://reviews.apache.org/r/59577/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>