You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Bertrand Delacretaz <bd...@apache.org> on 2010/09/20 14:22:13 UTC
What's our test coverage on the authentication stuff?
Hi,
I'm busy with non-Sling stuff at the moment, haven't been able to
follow the details but I see lots of changes around authentication
lately.
Do people feel we have adequate integration test coverage of those
things? I think the whole authentication process involves a number of
services, which can't probably be fully tested in isolation.
I had a quick look an it seems like the only integration test that's
directly linked to authentication is AuthRequestLoginTest [1].
If we need more of those, the best might be to create a JIRA issue to
which we can link all issues that might require new tests. I'm hopeful
to find some time to write those if needed ;-)
-Bertrand
[1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/login/AuthRequestLoginTest.java
Re: What's our test coverage on the authentication stuff?
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Am 20.09.2010 15:36, schrieb Bertrand Delacretaz:
> On Mon, Sep 20, 2010 at 3:24 PM, Felix Meschberger <fm...@gmail.com> wrote:
>> ...No, test coverage is not the best possible .... Though I do rather
>> thorough (but still) manual testing.
>>
>> Some tests can and should probably done in isolation while other tests
>> can only be done on an integration basis....
>>
>> Would be cool if you would find cycles to create some tests ;-)...
>
> Yes ;-)
>
> For now see SLING-1786 and please link any issues to it that are
> relevant to integration testing of the auth stuff.
Probably all of the "Compoents=Authentication" issues ;-)
Regards
Felix
Re: What's our test coverage on the authentication stuff?
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Sep 20, 2010 at 3:24 PM, Felix Meschberger <fm...@gmail.com> wrote:
> ...No, test coverage is not the best possible .... Though I do rather
> thorough (but still) manual testing.
>
> Some tests can and should probably done in isolation while other tests
> can only be done on an integration basis....
>
> Would be cool if you would find cycles to create some tests ;-)...
Yes ;-)
For now see SLING-1786 and please link any issues to it that are
relevant to integration testing of the auth stuff.
-Bertrand
Re: What's our test coverage on the authentication stuff?
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
No, test coverage is not the best possible .... Though I do rather
thorough (but still) manual testing.
Some tests can and should probably done in isolation while other tests
can only be done on an integration basis....
Would be cool if you would find cycles to create some tests ;-)
Regards
Felix
Am 20.09.2010 14:22, schrieb Bertrand Delacretaz:
> Hi,
>
> I'm busy with non-Sling stuff at the moment, haven't been able to
> follow the details but I see lots of changes around authentication
> lately.
>
> Do people feel we have adequate integration test coverage of those
> things? I think the whole authentication process involves a number of
> services, which can't probably be fully tested in isolation.
>
> I had a quick look an it seems like the only integration test that's
> directly linked to authentication is AuthRequestLoginTest [1].
>
> If we need more of those, the best might be to create a JIRA issue to
> which we can link all issues that might require new tests. I'm hopeful
> to find some time to write those if needed ;-)
>
> -Bertrand
>
> [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/login/AuthRequestLoginTest.java
>
Re: What's our test coverage on the authentication stuff?
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Yes, we do have a 2.6.x license available for committers only (I would
assume) working on ASF projects (packages below org.apache) and
obviously also supporting IntelliJ and Eclipse.
Regards
Felix
Am 20.09.2010 16:43, schrieb Justin Edelson:
> FWIW, the coverage is better than I thought -
> http://people.apache.org/~justin/coverage/
>
> I'm trying to get back to integrating emma fully into our build. But
> before I get too far, does anyone know if we have access to a Clover
> license? Clover, IMHO, produces nicer looking reports.
>
> Justin
>
> On 9/20/10 8:22 AM, Bertrand Delacretaz wrote:
>> Hi,
>>
>> I'm busy with non-Sling stuff at the moment, haven't been able to
>> follow the details but I see lots of changes around authentication
>> lately.
>>
>> Do people feel we have adequate integration test coverage of those
>> things? I think the whole authentication process involves a number of
>> services, which can't probably be fully tested in isolation.
>>
>> I had a quick look an it seems like the only integration test that's
>> directly linked to authentication is AuthRequestLoginTest [1].
>>
>> If we need more of those, the best might be to create a JIRA issue to
>> which we can link all issues that might require new tests. I'm hopeful
>> to find some time to write those if needed ;-)
>>
>> -Bertrand
>>
>> [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/login/AuthRequestLoginTest.java
>
>
Re: What's our test coverage on the authentication stuff?
Posted by Justin Edelson <ju...@gmail.com>.
FWIW, the coverage is better than I thought -
http://people.apache.org/~justin/coverage/
I'm trying to get back to integrating emma fully into our build. But
before I get too far, does anyone know if we have access to a Clover
license? Clover, IMHO, produces nicer looking reports.
Justin
On 9/20/10 8:22 AM, Bertrand Delacretaz wrote:
> Hi,
>
> I'm busy with non-Sling stuff at the moment, haven't been able to
> follow the details but I see lots of changes around authentication
> lately.
>
> Do people feel we have adequate integration test coverage of those
> things? I think the whole authentication process involves a number of
> services, which can't probably be fully tested in isolation.
>
> I had a quick look an it seems like the only integration test that's
> directly linked to authentication is AuthRequestLoginTest [1].
>
> If we need more of those, the best might be to create a JIRA issue to
> which we can link all issues that might require new tests. I'm hopeful
> to find some time to write those if needed ;-)
>
> -Bertrand
>
> [1] https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/login/AuthRequestLoginTest.java