You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Mayank Lahiri (JIRA)" <ji...@apache.org> on 2010/07/17 00:38:50 UTC

[jira] Created: (HIVE-1470) percentile_approx() fails with more than 1 reducer

percentile_approx() fails with more than 1 reducer
--------------------------------------------------

                 Key: HIVE-1470
                 URL: https://issues.apache.org/jira/browse/HIVE-1470
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
    Affects Versions: 0.6.0
            Reporter: Mayank Lahiri
            Assignee: Mayank Lahiri
             Fix For: 0.7.0
         Attachments: HIVE-1470.1.patch

The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1470:
-----------------------------

    Status: Open  (was: Patch Available)

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "Mayank Lahiri (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayank Lahiri updated HIVE-1470:
--------------------------------

    Attachment: HIVE-1470.2.patch

Added multiple reducers to test case, for eventual testing with minimr mode.

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch, HIVE-1470.2.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "Mayank Lahiri (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayank Lahiri updated HIVE-1470:
--------------------------------

    Status: Patch Available  (was: Open)

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "Mayank Lahiri (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayank Lahiri updated HIVE-1470:
--------------------------------

    Attachment: HIVE-1470.1.patch

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889981#action_12889981 ] 

John Sichi commented on HIVE-1470:
----------------------------------

How about this..post an updated patch which includes the test case, setting the number of reducers explicitly.  It will be ignored for now (so the test coverage won't actually be there yet), but I'll add a note on HIVE-117 that this is a test that needs to start running in minimr mode once HIVE-117 is fixed.


> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "Mayank Lahiri (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mayank Lahiri updated HIVE-1470:
--------------------------------

    Status: Patch Available  (was: Open)

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch, HIVE-1470.2.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889551#action_12889551 ] 

John Sichi commented on HIVE-1470:
----------------------------------

Oh...if it requires more than one reducer, we'll need minimr mode in order to exercise it, meaning I need to finish HIVE-117.


> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "Mayank Lahiri (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889971#action_12889971 ] 

Mayank Lahiri commented on HIVE-1470:
-------------------------------------

Should I create a dependency on HIVE-117? The only bit that was causing the code to crash has been removed with the split-up of the Evaluator class.

> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889550#action_12889550 ] 

John Sichi commented on HIVE-1470:
----------------------------------

Unit test?


> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892502#action_12892502 ] 

John Sichi commented on HIVE-1470:
----------------------------------

+1.  Will commit when tests pass.


> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch, HIVE-1470.2.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1470) percentile_approx() fails with more than 1 reducer

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1470:
-----------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

Committed.  Thanks Mayank!


> percentile_approx() fails with more than 1 reducer
> --------------------------------------------------
>
>                 Key: HIVE-1470
>                 URL: https://issues.apache.org/jira/browse/HIVE-1470
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: Mayank Lahiri
>            Assignee: Mayank Lahiri
>             Fix For: 0.7.0
>
>         Attachments: HIVE-1470.1.patch, HIVE-1470.2.patch
>
>
> The larger issue is that a UDAF that has variable return types needs two inner Evaluator classes. This patch fixes a NullPointerException bug that is only encountered when partial aggregations are invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.