You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/26 09:35:06 UTC

[GitHub] [incubator-eventmesh] dinghuang opened a new issue, #1889: Use the methods that have been extracted [rocketmq ConfigurationWrapper]

dinghuang opened a new issue, #1889:
URL: https://github.com/apache/incubator-eventmesh/issues/1889

   ![image](https://user-images.githubusercontent.com/20722776/197991475-d3046e4b-1d5a-4536-912a-9b9df947c9fe.png)
   
   located at:
   org/apache/eventmesh/connector/rocketmq/config/ConfigurationWrapper.java line 65
   Replace the code in the image using the method that has been extracted.
   this method is located at:
   org/apache/eventmesh/common/utils/PropertiesUtils.java loadPropertiesWhenFileExist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] NewtonVan commented on issue #1889: Use the methods that have been extracted [rocketmq ConfigurationWrapper]

Posted by GitBox <gi...@apache.org>.
NewtonVan commented on issue #1889:
URL: https://github.com/apache/incubator-eventmesh/issues/1889#issuecomment-1291821779

   I'll try my best to fix this, would u pls assign this to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] dinghuang commented on issue #1889: Use the methods that have been extracted [rocketmq ConfigurationWrapper]

Posted by GitBox <gi...@apache.org>.
dinghuang commented on issue #1889:
URL: https://github.com/apache/incubator-eventmesh/issues/1889#issuecomment-1292926935

   I have already push a commit to solve it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 closed issue #1889: [Enhancement] Use the methods that have been extracted [rocketmq ConfigurationWrapper]

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1889: [Enhancement] Use the methods that have been extracted [rocketmq ConfigurationWrapper]
URL: https://github.com/apache/incubator-eventmesh/issues/1889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] NewtonVan commented on issue #1889: Use the methods that have been extracted [rocketmq ConfigurationWrapper]

Posted by GitBox <gi...@apache.org>.
NewtonVan commented on issue #1889:
URL: https://github.com/apache/incubator-eventmesh/issues/1889#issuecomment-1292906287

   > I'll try my best to fix this, would u pls assign this to me?
   
   @xwm1992 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #1889: Use the methods that have been extracted [rocketmq ConfigurationWrapper]

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1889:
URL: https://github.com/apache/incubator-eventmesh/issues/1889#issuecomment-1291789586

   Welcome to the Apache EventMesh (incubating) community!!
   We are glad that you are contributing by opening this issue. :D
   
   Please make sure to include all the relevant context.
   We will be here shortly.
   
   If you are interested in contributing to our project, please let us know!
   You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
   
   Want to get closer to the community?
   
   WeChat Group:
   ![wechat_qr](https://github.com/apache/incubator-eventmesh/blob/master/docs/images/contact/wechat-assistant.jpg?raw=true)
   
   Mailing Lists:
   | Name | Description |Subscribe	|Unsubscribe|Archive
   | ----    | ----    |----    | ----    | ----    |
   |Users	|User support and questions mailing list|	[Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
   |Development	|Development related discussions|	[Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
   |Commits	|All commits to repositories|	[Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org