You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by Omkar20895 <gi...@git.apache.org> on 2016/10/27 20:26:09 UTC
[GitHub] climate pull request #418: CLIMATE-886 Updating front-end dependencies.
GitHub user Omkar20895 opened a pull request:
https://github.com/apache/climate/pull/418
CLIMATE-886 Updating front-end dependencies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Omkar20895/climate CLIMATE-886
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/418.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #418
----
commit 253b9973a17167a8f32b61a36ed059dccc1c00c2
Author: Omkar20895 <om...@gmail.com>
Date: 2016-10-25T13:16:32Z
CLIMATE-877 Adding PODAAC data source to OCW GUI
commit 830c937554f4dfb38f12fb62367f68550cb58e44
Author: Omkar20895 <om...@gmail.com>
Date: 2016-10-27T20:24:35Z
CLIMATE-886 Updating frontend dependencies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
I have a theory that I have learnt from my digging up on this kind of issues, the modules that we are using in turn have unmet dependencies and their respective owners need t update them, I am not sure regarding this, please correct me if I am wrong. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
Hi @Omkar20895 please merge the following into your remote branch and then test it out.
https://github.com/Omkar20895/climate/pull/1
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@lewismc yes I did. Just to be sure node dependencies is the only folder that npm install generates right?? If that's right then I did delete that folder and tried the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/418
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@jarifibrahim yes exactly, I got the same errors and I mentioned the same earlier, according to my understanding the errors are not caused due to our part of the code, I have updated every module to the latest version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
You've not addressed the README issue in the build. Also can you remove the PO.DAAC stuff?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by jarifibrahim <gi...@git.apache.org>.
Github user jarifibrahim commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895 `npm install` would create a folder `node_modules` and install all the dependencies in it. If you do `npm install -g` then the dependencies are installed globally.
I tried your PR and got the following errors
```
npm WARN deprecated graceful-fs@2.0.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated CSSselect@0.4.1: the module is now available as 'css-select'
npm WARN deprecated CSSwhat@0.4.7: the module is now available as 'css-what'
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated tough-cookie@0.9.15: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated minimatch@1.0.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated tough-cookie@0.12.1: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated npmconf@2.1.2: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN prefer global coffee-script@1.10.0 should be installed with -g
npm WARN prefer global jshint@2.9.4 should be installed with -g
+-- UNMET PEER DEPENDENCY jasmine-core@*
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.0.15: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN karma-jasmine@1.0.2 requires a peer of jasmine-core@* but none was installed.
```
Btw, [npm-check-update](https://www.npmjs.com/package/npm-check-updates) package might be useful in future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
I don't know how the first commit got in the way here. Anyways just try out the package.json once and I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895
http://stackoverflow.com/questions/18057466/npm-how-to-fix-no-readme-data
Please squash your commits if you could as well. Thanks, appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/418
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
Okay on it, Can you let me know what you wanted to add into the READme? I did not get that part. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/418
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/climate/pull/418
By the way in regards to the pydap tests failing: this is not on our end, but something the OPeNDAP folks need to fix. I have been in contact with their support team.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
Thats exactly right. There is nothing we can do about the deprecated transitive dependencies. Please merge in master branch.
One thing is that we need to run the tests as well
https://github.com/apache/climate/tree/master/ocw-ui/frontend/test
Can someone please open a new issue for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895 this is looking good. If you could just add the data to the README then I am +1 to merge into master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
Actually, hold off on the merge. This is not right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/418
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/418
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #418: CLIMATE-886 Updating front-end dependencies.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895 can you delete the node dependencies folder, try again with the fresh PR applied and post your output here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@lewismc I am on a vacation so I won't be able to do it, I am gonna update this as soon as I return to my university this sunday. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895 How are you creating the `virtualenv`? The `podaacpy` related errors that are being shown in the CI log output were fixed in 1.6.0 which is now on conda-forge. Are you certain that you are using this version in your testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@agoodm this is not regarding travis build this is regarding the node dependencies. Please correct me if I am wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@lewismc I have replicated the README in the root directory of climate and added to climate/ocw-ui/frontend. The warning was raised because npm was searching for readme data in ocw-ui. I also added a field readme in package.json, If this is alright then let me know and I will squash the commits and merge into master. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
I haven't tested the branch yet, I am testing it now. I merged your PR just now into my branch and hence it appeared here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by Omkar20895 <gi...@git.apache.org>.
Github user Omkar20895 commented on the issue:
https://github.com/apache/climate/pull/418
@lewismc I tried this PR out in a clean virtualenv and I still got the same errors. I think we need to take others opinion if everything is working fine in your system with this PR.
@agoodm @jarifibrahim can you please try this out? Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
+1 please squash merge. Thanks
On Sun, Nov 13, 2016 at 3:57 AM, Omkar <no...@github.com> wrote:
> @lewismc <https://github.com/lewismc> I have replicated the README in the
> root directory of climate and added to climate/ocw-ui/frontend. The warning
> was raised because npm was searching for readme data in ocw-ui. I also
> added a field readme in package.json, If this is alright then let me know
> and I will squash the commits and merge into master. Thanks :)
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/climate/pull/418#issuecomment-260181758>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABHJl6jhCRGWzoirUauToSFgkum_cNpwks5q9vs2gaJpZM4KiyTx>
> .
>
--
*Lewis*
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director, MCMA Associates
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
#dynamite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #418: CLIMATE-886 Updating front-end dependencies.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/418
@Omkar20895 have you tried deleting the npm-generated material in the ocw-ui directory and trying again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---