You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2021/11/02 03:26:23 UTC

[GitHub] [incubator-sedona] Zeratal opened a new pull request #559: Fix showcase execution bug

Zeratal opened a new pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559


   ## Is this PR related to a proposed Issue?
   
   ## What changes were proposed in this PR?
   
   ## How was this patch tested?
   
   ## Did this PR include necessary documentation updates?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu merged pull request #559: [SEDONA-72 ] Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu merged pull request #559: [SEDONA-72 ] Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #559: [Apache SedonaSEDONA-72 ]Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559#discussion_r741338682



##########
File path: core/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala
##########
@@ -56,7 +56,7 @@ object ScalaExample extends App {
   val PolygonRDDSplitter = FileDataSplitter.CSV
   val PolygonRDDNumPartitions = 5
   val PolygonRDDStartOffset = 0
-  val PolygonRDDEndOffset = 8
+  val PolygonRDDEndOffset = 9// 8      modified by wjp 2021.11.2

Review comment:
       Please remove the comment in this line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu merged pull request #559: [SEDONA-72 ] Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] Zeratal commented on a change in pull request #559: [SEDONA-72 ]Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
Zeratal commented on a change in pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559#discussion_r741572808



##########
File path: core/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala
##########
@@ -56,7 +56,7 @@ object ScalaExample extends App {
   val PolygonRDDSplitter = FileDataSplitter.CSV
   val PolygonRDDNumPartitions = 5
   val PolygonRDDStartOffset = 0
-  val PolygonRDDEndOffset = 8
+  val PolygonRDDEndOffset = 9// 8      modified by wjp 2021.11.2

Review comment:
       done
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu merged pull request #559: [SEDONA-72 ] Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu merged pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] Zeratal commented on a change in pull request #559: [SEDONA-72 ]Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
Zeratal commented on a change in pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559#discussion_r741572808



##########
File path: core/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala
##########
@@ -56,7 +56,7 @@ object ScalaExample extends App {
   val PolygonRDDSplitter = FileDataSplitter.CSV
   val PolygonRDDNumPartitions = 5
   val PolygonRDDStartOffset = 0
-  val PolygonRDDEndOffset = 8
+  val PolygonRDDEndOffset = 9// 8      modified by wjp 2021.11.2

Review comment:
       done
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] jiayuasu commented on a change in pull request #559: [Apache SedonaSEDONA-72 ]Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on a change in pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559#discussion_r741338682



##########
File path: core/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala
##########
@@ -56,7 +56,7 @@ object ScalaExample extends App {
   val PolygonRDDSplitter = FileDataSplitter.CSV
   val PolygonRDDNumPartitions = 5
   val PolygonRDDStartOffset = 0
-  val PolygonRDDEndOffset = 8
+  val PolygonRDDEndOffset = 9// 8      modified by wjp 2021.11.2

Review comment:
       Please remove the comment in this line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-sedona] Zeratal commented on a change in pull request #559: [SEDONA-72 ]Fix showcase execution bug

Posted by GitBox <gi...@apache.org>.
Zeratal commented on a change in pull request #559:
URL: https://github.com/apache/incubator-sedona/pull/559#discussion_r741572808



##########
File path: core/src/main/scala/org/apache/sedona/core/showcase/ScalaExample.scala
##########
@@ -56,7 +56,7 @@ object ScalaExample extends App {
   val PolygonRDDSplitter = FileDataSplitter.CSV
   val PolygonRDDNumPartitions = 5
   val PolygonRDDStartOffset = 0
-  val PolygonRDDEndOffset = 8
+  val PolygonRDDEndOffset = 9// 8      modified by wjp 2021.11.2

Review comment:
       done
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org