[jira] [Comment Edited] (PHOENIX-6660) Ship reload4j in queryserver assembly

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500131#comment-17500131 ] 

Istvan Toth edited comment on PHOENIX-6660 at 3/2/22, 1:05 PM:
---------------------------------------------------------------

Adding the logging jars explicitly also means that
 * we switch PQS to work with the embedded client jar, to avoid slf4j backend jar conflicts
 * we also add real logging to sqlline-thin.py, so that its logging works much like sqlline.py


was (Author: stoty):
Adding the logging jars explicitly also means that
 * we switches PQS to work with the embedded client jar, to avoid slf4j backend jar conflicts
 * we also add real logging to sqlline-thin.py, so that its logging works much like sqlline.py

> Ship reload4j in queryserver assembly
> -------------------------------------
>
>                 Key: PHOENIX-6660
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6660
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: queryserver
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Queryserver currently doesn't ship any "real" logging backend, it only adds slf4j-simple.
> If you add the non embedded phoenix-client, then it will pick up the slf4j backend and slf4j from it, and work, but if you use phoenix-client-embedded, you only get the very limited slf4j-simple backend.
> Add reload4j to the assembly, and change the scripts to load those JARs.
> Also document that you should use the embedded client, and how to remove the bundled logging jars if you use the non-embedded client.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)