[jira] [Updated] (SLING-4427) Inneficient JcrNode.hashCode and equals

["Robert Munteanu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu updated SLING-4427:
-----------------------------------
    Fix Version/s:     (was: Sling Eclipse IDE 1.1.0)
                   Sling Eclipse IDE 1.1.2

> Inneficient JcrNode.hashCode and equals
> ---------------------------------------
>
>                 Key: SLING-4427
>                 URL: https://issues.apache.org/jira/browse/SLING-4427
>             Project: Sling
>          Issue Type: Bug
>          Components: IDE
>    Affects Versions: Sling Eclipse IDE 1.0.4
>            Reporter: Robert Munteanu
>             Fix For: Sling Eclipse IDE 1.1.2
>
>
> On certain paths, JcrNode equals and hashcode perform copies of the their domElement, manipulate them and use them for equals/hashCode computations, e.g.
> {code:java}			Element domElementCopy = domElement.copy();
> 			domElementCopy.clearChildren();
> 			Element otherDomElementCopy = other.domElement.copy();
> 			otherDomElementCopy.clearChildren();
> 			return domElementCopy.toString().equals(otherDomElementCopy.toString());{code}
> This has the potential to be quite expensive and should be corrected



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)