You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@icorps.com> on 2012/07/26 16:34:59 UTC
Review Request: Fix Page Rendering before share is accepted
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/
-----------------------------------------------------------
Review request for rave.
Description
-------
For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541
Diff: https://reviews.apache.org/r/6154/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Posted by Daniel Gornstein <dg...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/
-----------------------------------------------------------
(Updated July 30, 2012, 1:15 p.m.)
Review request for rave.
Changes
-------
Regarding Matt's comments, I moved the code back to the script block and preformed the logic to test if the page status is PENDING there.
This fix makes it so shared pages which are not yet accepted by the user, does not get rendered in the background.
Description
-------
For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1367061
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1367061
Diff: https://reviews.apache.org/r/6154/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/#review9560
-----------------------------------------------------------
One minor issue. We want to keep logic in the script blocks on page light; but want to ensure we are keeping good separation of concerns as well.
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js
<https://reviews.apache.org/r/6154/#comment20419>
To be consistent with the rest of the application flow, I would move this logic back to the script block. initializing the UI, pageLayouts, etc should be managed by the object being rendered (IE the page)
- Matt Franklin
On July 27, 2012, 5:18 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6154/
> -----------------------------------------------------------
>
> (Updated July 27, 2012, 5:18 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1365541
> trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1365541
> trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541
>
> Diff: https://reviews.apache.org/r/6154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Posted by Daniel Gornstein <dg...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/
-----------------------------------------------------------
(Updated July 27, 2012, 5:18 p.m.)
Review request for rave.
Changes
-------
This is a second fix which does NOT render the content of the page at all instead of hiding and showing it.
Description
-------
For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
Diffs (updated)
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1365541
trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1365541
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541
Diff: https://reviews.apache.org/r/6154/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave 711: Fix Page Rendering before share is accepted
Posted by Daniel Gornstein <dg...@icorps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6154/
-----------------------------------------------------------
(Updated July 27, 2012, 11:35 a.m.)
Review request for rave.
Summary (updated)
-----------------
Rave 711: Fix Page Rendering before share is accepted
Description
-------
For this fix I have added code to hide the region with the content of the page until accept is pressed. After accept is pressed on the callback it reloads the page which shows the content of the page. If I just did a .show() the resizing of the gadgets was not correct.
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541
Diff: https://reviews.apache.org/r/6154/diff/
Testing
-------
Thanks,
Daniel Gornstein