You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/08 09:41:55 UTC
[GitHub] [apisix] rampagecong opened a new pull request, #6811: fix: add support for multi-header with same key
rampagecong opened a new pull request, #6811:
URL: https://github.com/apache/apisix/pull/6811
### Description
add support for multi-header with same key like `set-cookie`
Fixes # (issue)
https://github.com/apache/apisix-go-plugin-runner/issues/74
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] rampagecong commented on pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
rampagecong commented on PR #6811:
URL: https://github.com/apache/apisix/pull/6811#issuecomment-1096463034
> @rampagecong Could you apply the same fix to other headers? Thanks!
No problem. I'll make time to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] rampagecong commented on a diff in pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
rampagecong commented on code in PR #6811:
URL: https://github.com/apache/apisix/pull/6811#discussion_r846894201
##########
t/lib/ext-plugin.lua:
##########
@@ -373,6 +373,40 @@ function _M.go(case)
{"X-Req", "bar"},
{"Content-Type", "application/json"},
{"Content-Encoding", "deflate"},
+ {"X-Same", "one"},
Review Comment:
Sorry, I optimized the code.I divided it into three test cases based on this feature.
TEST 19: rewrite response header and call the upstream service
TEST 20: rewrite non-important response headers and call the upstream service
TEST 25: rewrite same response headers and call the upstream service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #6811:
URL: https://github.com/apache/apisix/pull/6811#discussion_r846772707
##########
t/lib/ext-plugin.lua:
##########
@@ -373,6 +373,40 @@ function _M.go(case)
{"X-Req", "bar"},
{"Content-Type", "application/json"},
{"Content-Encoding", "deflate"},
+ {"X-Same", "one"},
Review Comment:
We don't need X-Same for other header tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #6811:
URL: https://github.com/apache/apisix/pull/6811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
spacewander commented on PR #6811:
URL: https://github.com/apache/apisix/pull/6811#issuecomment-1096449186
@rampagecong
Could you apply the same fix to other headers? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #6811:
URL: https://github.com/apache/apisix/pull/6811#discussion_r846977462
##########
t/lib/ext-plugin.lua:
##########
@@ -373,6 +373,40 @@ function _M.go(case)
{"X-Req", "bar"},
{"Content-Type", "application/json"},
{"Content-Encoding", "deflate"},
+ {"X-Same", "one"},
Review Comment:
Don't worry, it's just a small problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] rampagecong commented on pull request #6811: fix: add support for multi-header with same key
Posted by GitBox <gi...@apache.org>.
rampagecong commented on PR #6811:
URL: https://github.com/apache/apisix/pull/6811#issuecomment-1092676132
@spacewander Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org