[jira] [Commented] (CLOUDSTACK-9239) lock account silently fails

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105567#comment-15105567 ] 

ASF GitHub Bot commented on CLOUDSTACK-9239:
--------------------------------------------

GitHub user DaanHoogland opened a pull request:

    https://github.com/apache/cloudstack/pull/1349

    CLOUDSTACK-9239 throw exception on deprecated command

    an API call to LockAccount fails silently with a 200 return and no contents. client are responsible to check and will find that no locking has actually occured. This way they may be lured to a sense of false security.
    Throwing an exption makes the failure explicit.
    cloudmonkey lock account name=<name> domainid=<id>
    now errors out with an http result of 530

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9239

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1349
    
----
commit 28e17165c0105caa09c54105863944ff156a19f0
Author: Daan Hoogland <da...@onecht.net>
Date:   2016-01-18T14:01:33Z

    CLOUDSTACK-9239 throw exception on deprecated command

----


> lock account silently fails
> ---------------------------
>
>                 Key: CLOUDSTACK-9239
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9239
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>
> lock account has an implementation consisting of a commented out contents of the execute method, hence it silently fails.
> We should throw at least a CloudRuntimeException or a NotImplemetedException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)