You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "moonming (via GitHub)" <gi...@apache.org> on 2023/04/17 07:44:25 UTC

[GitHub] [apisix] moonming commented on a diff in pull request #9312: fix:grpc_set_header Te trailers

moonming commented on code in PR #9312:
URL: https://github.com/apache/apisix/pull/9312#discussion_r1168305842


##########
apisix/cli/ngx_tpl.lua:
##########
@@ -766,6 +766,7 @@ http {
             grpc_set_header   "Host" $upstream_host;
             {% end %}
             grpc_set_header   Content-Type application/grpc;
+            grpc_set_header   Te trailers;

Review Comment:
   It should not be hard code here. 
   If the client does not ask for Trailer, it should not return this header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org