You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Felix Röthenbacher (JIRA)" <ji...@codehaus.org> on 2008/10/29 04:56:51 UTC
[jira] Created: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Update to Checkstyle 5.0-beta01
-------------------------------
Key: MCHECKSTYLE-105
URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
Project: Maven 2.x Checkstyle Plugin
Issue Type: Improvement
Affects Versions: 2.3
Reporter: Felix Röthenbacher
Attachments: patch.diff
Checkstyle 5.0-beta01 adds support for generics, etc.
See
http://checkstyle.sourceforge.net/5.x/releasenotes.html
for a list of new features.
Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=193765#action_193765 ]
Dennis Lundberg commented on MCHECKSTYLE-105:
---------------------------------------------
Nicolas de Loof went and applied this patch before, but at that time it was a bit premature. There was a discussion about how we should handle plugins that requires Java 1.5 on the dev list. His commit was rolled back and then I did a release of what was in trunk so that our Java 1.4 users could benefit from the latest additions to the plugin.
After that I thought that Nicolas was going to go forward with this issue, but that hasn't happened.
I'm willing to apply the patch, deploy a SNAPSHOT and do a release, if I can get some testing/feedback from you guys on the SNAPSHOT. Does that sound like a good plan? Who's willing to help test the SNAPSHOT?
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194726#action_194726 ]
Mark Hobson commented on MCHECKSTYLE-105:
-----------------------------------------
Sorry, I thought I was watching this issue and had no feedback! Dennis, please do apply the patch and deploy a snapshot, or I'm happy to do it myself if that's easier.
I've been using it without problems since my last comment, and am happy to provide feedback.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "jieryn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194861#action_194861 ]
jieryn commented on MCHECKSTYLE-105:
------------------------------------
I just tried out the 2.4-SNAPSHOT using the following configuration, and running directly with *mvn checkstyle:checkstyle*, and also from *mvn site*. I don't detect anything out of the ordinary, nice job!
\\
{code}
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.4-SNAPSHOT</version>
<configuration>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<configLocation>${project.build.directory}/maven-shared-archive-resources/com/ibm/isvt/checkstyle.xml</configLocation>
<headerLocation>licenses/LICENSE-java</headerLocation>
<xrefLocation>${project.reporting.outputDirectory}/${xref.depth}/xref</xrefLocation>
</configuration>
</plugin>
{code}
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-105) Update to Checkstyle
5.0-beta01
Posted by "Travis Schneeberger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170842#action_170842 ]
Travis Schneeberger edited comment on MCHECKSTYLE-105 at 3/24/09 1:36 PM:
--------------------------------------------------------------------------
Checkstyle 5 is now in the second beta release... http://checkstyle.sourceforge.net/releasenotes.html
Has anyone tested this patch on the second release?
was (Author: tschneeberger):
Checkstyle 5 is now in there second beta release... http://checkstyle.sourceforge.net/releasenotes.html
Has anyone tested this patch on the second release?
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Max Berger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Berger updated MCHECKSTYLE-105:
-----------------------------------
Attachment: update-to-5.0-812221.patch
still same patch, updated for SVN 81278.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Sébastien PRUNIER (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=195213#action_195213 ]
Sébastien PRUNIER commented on MCHECKSTYLE-105:
-----------------------------------------------
2.4-SNAPSHOT tested with a custom configuration file, it works fine. No problem for me.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Travis Schneeberger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=173555#action_173555 ]
Travis Schneeberger commented on MCHECKSTYLE-105:
-------------------------------------------------
Checkstyle 5 is now released in it's final form....http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0
Enjoy!
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-105) Update to Checkstyle
5.0
Posted by "Ben Speakmon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176171#action_176171 ]
Ben Speakmon edited comment on MCHECKSTYLE-105 at 5/12/09 1:43 PM:
-------------------------------------------------------------------
Checkstyle 5.0 final is now in maven. After the above patches for beta 2 were applied, no further updates were required to our vendor branch for 5.0 final.
As far as I know, maven is still a JDK 1.4 app, so there is resistance to using something that requires JDK 5 or later. It doesn't really make sense to retrotranslate this plugin, so we're at an impasse.
I've published my build with the patches in our public maven repo: http://maven.atlassian.com/repository/public/org/apache/maven/plugins/maven-checkstyle-plugin. The version is 2.3-atlassian-1.
Source is at http://svn.atlassian.com/fisheye/browse/public/atlassian/vendor/maven-checkstyle-plugin-2.3.
All who would like to use this are welcome. (Needless to say, we don't support this in any way.)
was (Author: bens):
Checkstyle 5.0 final is now in maven. After the above patches for beta 2 were applied, no further updates were required to our vendor branch for 5.0 final.
As far as I know, maven is still a JDK 1.4 app, so there is resistance to using something that requires JDK 5 or later. It doesn't really make sense to retrotranslate this plugin, so we're at an impasse.
I've published my build with the patches in our public maven repo: http://maven.atlassian.com/repository/public/org/apache/maven/plugins/maven-checkstyle-plugin.
Source is at http://svn.atlassian.com/fisheye/browse/public/atlassian/vendor/maven-checkstyle-plugin-2.3.
All who would like to use this are welcome. (Needless to say, we don't support this in any way.)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nicolas de loof reopened MCHECKSTYLE-105:
-----------------------------------------
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=193497#action_193497 ]
Olivier Lamy commented on MCHECKSTYLE-105:
------------------------------------------
I think the main issue is 1.5 required.
But if you have to commit this do it quickly because 1.5 end support by sun is [30 October 09|http://java.sun.com/products/archive/eol.policy.html]
Yes I know a little bit ironical comment :P
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Sébastien PRUNIER (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194373#action_194373 ]
Sébastien PRUNIER commented on MCHECKSTYLE-105:
-----------------------------------------------
I can help to test the snapshot too.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194821#action_194821 ]
Mark Hobson commented on MCHECKSTYLE-105:
-----------------------------------------
Thanks Dennis. I've just tried the latest deployed snapshot with a custom checkstyle file and it works fine.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Martin Zeltner (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194853#action_194853 ]
Martin Zeltner commented on MCHECKSTYLE-105:
--------------------------------------------
For those how do not want to work with snapshots (or not allowed to) I have just added the plugin with r825243 on our company's Public Maven 2 repo (el4j.sourceforge.net):
Repo-URL: http://el4.elca-services.ch/el4j/maven2repository
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.4-el4j_20091015_1200</version>
</plugin>
Cheers
Martin
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Ben Speakmon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Speakmon updated MCHECKSTYLE-105:
-------------------------------------
Attachment: update-to-5.0beta2.patch
Here's a new patch for 5.0 beta 2. All tests pass. (The original patch will NOT work.)
Tested and working fine on our vendor branch at work.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "francisdb (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182268#action_182268 ]
francisdb commented on MCHECKSTYLE-105:
---------------------------------------
Maven 2.2.0 was released today which drops Java 1.4 support...
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=193496#action_193496 ]
Mark Hobson commented on MCHECKSTYLE-105:
-----------------------------------------
Is there any good reason why I can't commit this patch to trunk? I've tried it locally and it seems to work fine.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Zaccret (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155483#action_155483 ]
Zaccret commented on MCHECKSTYLE-105:
-------------------------------------
checkstyle.checkstyle 5.0-beta01 artifact is now in Maven central repository.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196689#action_196689 ]
Mark Hobson commented on MCHECKSTYLE-105:
-----------------------------------------
Looks like no-one is encountering any issues with this. Shall we close this and get a 2.4 release out of the door?
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Ben Speakmon (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176171#action_176171 ]
Ben Speakmon commented on MCHECKSTYLE-105:
------------------------------------------
Checkstyle 5.0 final is now in maven. After the above patches for beta 2 were applied, no further updates were required to our vendor branch for 5.0 final.
As far as I know, maven is still a JDK 1.4 app, so there is resistance to using something that requires JDK 5 or later. It doesn't really make sense to retrotranslate this plugin, so we're at an impasse.
I've published my build with the patches in our public maven repo: http://maven.atlassian.com/repository/public/org/apache/maven/plugins/maven-checkstyle-plugin.
Source is at http://svn.atlassian.com/fisheye/browse/public/atlassian/vendor/maven-checkstyle-plugin-2.3.
All who would like to use this are welcome. (Needless to say, we don't support this in any way.)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Aleksander Adamowski (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179125#action_179125 ]
Aleksander Adamowski commented on MCHECKSTYLE-105:
--------------------------------------------------
So when are 2.4 snapshots hitting the central repository?
This whole deal with 2.3-SNAPSHOT moving to Checkstyle 5.0 with version maven-checkstyle-plugin-2.3-20090518.081942-2, then going back to Checkstyle 4.4 in maven-checkstyle-plugin-2.3-20090531.103812-3 got me really confused.
I'd like an artifact version that uses a concrete version of Checkstyle and doesn't jump between CS 4 and 5 forth and back...
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "jieryn (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=183943#action_183943 ]
jieryn commented on MCHECKSTYLE-105:
------------------------------------
PING! Please, this is the most voted and watched JIRA for Checkstyle. Push out the 2.4 release which supports Checkstyle 5.0. This is a major upgrade. Current Maven doesn't even support Java 1.4 any more, this seems a non-issue now.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "René Zanner (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196775#action_196775 ]
René Zanner commented on MCHECKSTYLE-105:
-----------------------------------------
Yes - please! :o)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-105) Update to Checkstyle
5.0
Posted by "Steve Gorczyca (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197876#action_197876 ]
Steve Gorczyca edited comment on MCHECKSTYLE-105 at 11/10/09 1:35 PM:
----------------------------------------------------------------------
I'm using the version posted by Martin Zeltner and have run into no issues. Is java 1.4 support really still a requirement moving forward?
was (Author: sgorczyca):
I'm using the version posted by Martin Zeltner and have run into no issues. Is java 1.4 support really a requirement moving forward?
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Martin Jaeger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=193807#action_193807 ]
Martin Jaeger commented on MCHECKSTYLE-105:
-------------------------------------------
I will be happy to test it on my projects and provide feedback when you create the SNAPSHOT.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nicolas de loof updated MCHECKSTYLE-105:
----------------------------------------
Fix Version/s: (was: 2.3)
2.4
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Christoph Amshoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179164#action_179164 ]
Christoph Amshoff commented on MCHECKSTYLE-105:
-----------------------------------------------
This is a rather critical issue people are waiting to be fixed...!
So, instead of suggesting to execute the checkout-patch-build-deploy phases locally by everybody, how about providing something like an official 2.4-SNAPSHOT version? Or maybe 2.4-alpha since we were told to not use SNAPSHOT versions of plugins? What are the plans?
Java 5 is out now for quite a while, and it's annoying how the Checkstyle/Maven toolchain continues to ignore this fact, so **please** let's have progress here.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Winston Rast (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170840#action_170840 ]
Winston Rast commented on MCHECKSTYLE-105:
------------------------------------------
I would also like to see a new plugin using Checkstyle 5. Even a beta would be great.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MCHECKSTYLE-105:
----------------------------------------
Affects Version/s: (was: 2.3)
2.2
Fix Version/s: (was: 2.3)
Summary: Update to Checkstyle 5.0 (was: Update to Checkstyle 5.0-beta01)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194747#action_194747 ]
Dennis Lundberg commented on MCHECKSTYLE-105:
---------------------------------------------
Patch applied in [r825234|http://svn.apache.org/viewvc?view=rev&revision=825234] with modifications. Thanks!
I modified the *checks.xml files so that their behavior is unaltered from the previous version.
A new 2.4-SNAPSHOT ha been deployed to the SNAPSHOT repository for testing.
When I took the patched plugin for a test drive, I wasn't able to get it to pick up the (builtin) checks.xml file I wanted. Has anyone else experienced that?
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Mark Hobson (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hobson closed MCHECKSTYLE-105.
-----------------------------------
Resolution: Fixed
Assignee: Mark Hobson
Patch has been committed a while back and no problems reported since, so closing this issue.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: Mark Hobson
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Steve Gorczyca (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197876#action_197876 ]
Steve Gorczyca commented on MCHECKSTYLE-105:
--------------------------------------------
I'm using the version posted by Martin Zeltner and have run into no issues. Is java 1.4 support really a requirement moving forward?
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179170#action_179170 ]
nicolas de loof commented on MCHECKSTYLE-105:
---------------------------------------------
You don't need to convince me about java5
I plan to call for a vote on checkstyle plugin for a 2.3.
I could also start the 2.4 branch now and deploy a first SNAPSHOT
The only reason this is not yet done is lack of time !
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Tom Schmidt (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=190348#action_190348 ]
Tom Schmidt commented on MCHECKSTYLE-105:
-----------------------------------------
Any thought on cutting a 2.4 version of the plugin to support Checkstyle 5.0? We're using Sonar which depends on the Maven plugin and it looks like they are waiting for an official cut before updating the Sonar plugin.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=184848#action_184848 ]
Dennis Lundberg commented on MCHECKSTYLE-105:
---------------------------------------------
As discussed on the dev list, I released version 2.3 of what was in trunk as the last Java 1.4 compatible Checkstyle Plugin version.
Nicolas, you can go ahead with the upgrade to Checkstyle 5 if you have the time. If you don't have the time then please remove yourself as Assignee for this issue, so someone else can step up.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=165688#action_165688 ]
Dennis Lundberg commented on MCHECKSTYLE-105:
---------------------------------------------
Checkstyle 5 requires Java 1.5 so we would need a retrotranslated version that works with Java 1.4 first.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Travis Schneeberger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=170842#action_170842 ]
Travis Schneeberger commented on MCHECKSTYLE-105:
-------------------------------------------------
Checkstyle 5 is now in there second beta release... http://checkstyle.sourceforge.net/releasenotes.html
Has anyone tested this patch on the second release?
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nicolas de loof closed MCHECKSTYLE-105.
---------------------------------------
Assignee: nicolas de loof
Resolution: Fixed
Fix Version/s: 2.3
Fixed in SVN with update to Checkstyle 5.0
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.3
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Felix Röthenbacher (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166140#action_166140 ]
Felix Röthenbacher commented on MCHECKSTYLE-105:
------------------------------------------------
J2SE 1.4.2 reached the end of its service life (EOSL). Anyone who uses the Maven Checkstyle plugin with Java 1.4 can still use plugin version 2.2.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Max Berger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Max Berger updated MCHECKSTYLE-105:
-----------------------------------
Attachment: update-to-5.0.patch
old patch modified to depend on 5.0 final, based on current SVN (792869)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MCHECKSTYLE-105:
--------------------------------------
Fix Version/s: 2.3
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=197891#action_197891 ]
Dennis Lundberg commented on MCHECKSTYLE-105:
---------------------------------------------
@Steve, no next version will require java 1.5. The release will come shortly.
See the road map for more info.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Eric Chatellier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=193810#action_193810 ]
Eric Chatellier commented on MCHECKSTYLE-105:
---------------------------------------------
I can test snapshot too.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=179137#action_179137 ]
nicolas de loof commented on MCHECKSTYLE-105:
---------------------------------------------
2.3-20090518.081942-2 was my mistake : we decided the plugin should have a last release with java 1.4 support before moving to java5 (and checkstyle 5). For this reason this issue has been reverted and delayed to a future 2.4 - there is no snapshot yet (you can build and install one in your own managed repository if you wish)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Eric Chatellier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194819#action_194819 ]
Eric Chatellier commented on MCHECKSTYLE-105:
---------------------------------------------
Just tested with custom checkstyle.xml file.
Works as excepted.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Stevo Slavic (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=192905#action_192905 ]
Stevo Slavic commented on MCHECKSTYLE-105:
------------------------------------------
>From [this comment from Stephen Connolly|http://www.nabble.com/Re%3A-buildnumber-plugin-p25395826.html] I guess it would help if the patch included integration tests - with them maybe the new version with checkstyle 5 support could be released before Maven 3.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Christoph Amshoff (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=175284#action_175284 ]
Christoph Amshoff commented on MCHECKSTYLE-105:
-----------------------------------------------
Folks, what is the status here? If there already is a working patch available, what else is required to build a new release of this plugin?
This is really critical, so can we please have a new version -- even some beta version would do it...!
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0
Posted by "Marcin Zajaczkowski (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=194730#action_194730 ]
Marcin Zajaczkowski commented on MCHECKSTYLE-105:
-------------------------------------------------
I've been using attached patch with SVN snapshot without any problem as well.
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0-812221.patch, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MCHECKSTYLE-105) Update to Checkstyle 5.0-beta01
Posted by "Travis Schneeberger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=169100#action_169100 ]
Travis Schneeberger commented on MCHECKSTYLE-105:
-------------------------------------------------
Does anyone know the status of the patch? For those now using Java 5 and above CheckStyle 5 fixes a lot of bugs. This is an important patch for those building with Maven and using CheckStyle.
> Update to Checkstyle 5.0-beta01
> -------------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Felix Röthenbacher
> Fix For: 2.3
>
> Attachments: patch.diff
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MCHECKSTYLE-105) Update to Checkstyle
5.0
Posted by "Max Berger (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCHECKSTYLE-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=184243#action_184243 ]
Max Berger edited comment on MCHECKSTYLE-105 at 7/21/09 4:44 AM:
-----------------------------------------------------------------
update-to-5.0.patch: old patch modified to depend on 5.0 final, based on current SVN (792869)
was (Author: maxberger):
old patch modified to depend on 5.0 final, based on current SVN (792869)
> Update to Checkstyle 5.0
> ------------------------
>
> Key: MCHECKSTYLE-105
> URL: http://jira.codehaus.org/browse/MCHECKSTYLE-105
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Felix Röthenbacher
> Assignee: nicolas de loof
> Fix For: 2.4
>
> Attachments: patch.diff, update-to-5.0.patch, update-to-5.0beta2.patch
>
>
> Checkstyle 5.0-beta01 adds support for generics, etc.
> See
> http://checkstyle.sourceforge.net/5.x/releasenotes.html
> for a list of new features.
> Note: Prerequisite is that checkstyle-all jar, version 5.0-beta01 is available from a public Maven repository.
> Patch updates plugin to changed API / implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira