You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/06/27 22:20:26 UTC

[GitHub] madlib pull request #284: SVM: Fix flaky dev-check failure

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/madlib/pull/284

    SVM: Fix flaky dev-check failure

    JIRA: MADLIB-1232
    
    SVM has a dev-check query that is flaky on a large cluster. This commit
    relaxes the assert condition for that query.
    
    Closes #284

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/madlib/madlib bugfix/svm-flaky-dev-check

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #284
    
----
commit 9c556816bcca990e9b168cf556ce0da0cacf935a
Author: Nandish Jayaram <nj...@...>
Date:   2018-06-27T19:40:19Z

    SVM: Fix flaky dev-check failure
    
    JIRA: MADLIB-1232
    
    SVM has a dev-check query that is flaky on a large cluster. This commit
    relaxes the assert condition for that query.
    
    Closes #284

----


---

[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

Posted by iyerr3 <gi...@git.apache.org>.

Github user iyerr3 commented on the issue:

    https://github.com/apache/madlib/pull/284
  
    This test isn't necessarily the best thing to check but if we do want to keep it with some relaxed constraints then maybe we allow the norm to go higher by a small amount iff the total loss is lower. So something along the lines of 
    ```
    norm2(l2.coef) < norm2(noreg.coef) OR
        ( (norm2(l2.coef)-norm2(noreg.coef))/norm2(noreg.coef) < 0.1 AND l2.loss < noreg.loss),
    ```


---

[GitHub] madlib pull request #284: SVM: Fix flaky dev-check failure

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/284


---

[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/284
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/527/



---

[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

Posted by njayaram2 <gi...@git.apache.org>.

Github user njayaram2 commented on the issue:

    https://github.com/apache/madlib/pull/284
  
    Thank you for the comment @iyerr3 , will relax the constraint as suggested.


---

[GitHub] madlib issue #284: SVM: Fix flaky dev-check failure

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/284
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/528/



---