You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/04 07:10:23 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #8379: Support OAP server v9 Core concept: Layer, backend side
wankai123 opened a new pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379
### Support OAP server v9 Core concept: Layer, backend side
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [X] Update the documentation to include this new feature.
- [X] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
related to: #8241
previous review: https://github.com/apache/skywalking/pull/8367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777867341
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
+
+## Compatibility from previous version
+1. The query-protocol [metadata-v1](https://github.com/apache/skywalking-query-protocol/blob/master/metadata.graphqls) is provided on the top of the v2 implementation.
+ All query-protocol could be compatible with previous query.
+2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add argument `Layer`(require). Previous MAL expressions with this function should add this argument.
+3. LAL: [Extractor](../../../docs/en/concepts-and-designs/lal.md) add function `layer`. If don't set it manual, the default layer is `GENERAL` and the logs from `ALS` the
+ default layer is `mesh`.
+4. Storage：Table `ServiceTraffic` add columns `service_id`， `short_name` and `layer`，table `InstanceTraffic` add columns `layer`.
+ These data would be incompatible with previous in some storage, including H2/OpenSearch/MySQL/TiDB/InfluxDB/PostgreSQL.
+ Make sure to remove the older table `ServiceTraffic` and `InstanceTraffic` before OAP(v9) starts.
Review comment:
```suggestion
Make sure to remove the older `ServiceTraffic` and `InstanceTraffic` tables before OAP(v9) starts.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777870245
##########
File path: docs/en/concepts-and-designs/overview.md
##########
@@ -27,6 +27,10 @@ In addition, you can integrate
1. Other distributed tracing using SkyWalking native agents and SDKs with Zipkin, Jaeger and OpenCensus.
1. Other metrics systems, such as Prometheus, Sleuth(Micrometer), OpenTelemetry.
+Starting from v9, SkyWalking introduces the new core concept **Layer**.
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
Review comment:
Please move `layer` after `SkyWalking allows users to understand the topology relationship between Services and Endpoints, to view the metrics of every Service/Service Instance/Endpoint and to set alarm rules.`.
And should declare `layer` directly, as this would not be the change log or upgrade guidance
```markdown
A **layer** represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
Kubernetes(k8s layer). All detected instances belong to a layer to represent the running environment of this instance, the service would have one or multiple layer definitions according to its instances.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777878389
##########
File path: CHANGES.md
##########
@@ -22,6 +22,7 @@ Release Notes.
name doesn't exist in TCP traffic.
* Upgrade H2 version to 2.0.202 to fix CVE-2021-23463.
* Extend column name override mechanism working for `ValueColumnMetadata`.
+* Introduce new concept `Layer` and removed `NodeType`. More details refer to [v9-version-upgrade](docs/en/FAQ/v9-version-upgrade.md)
Review comment:
This link has been updated after the releasing, as this file will be moved into `changes` folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777867867
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
+
+## Compatibility from previous version
+1. The query-protocol [metadata-v1](https://github.com/apache/skywalking-query-protocol/blob/master/metadata.graphqls) is provided on the top of the v2 implementation.
+ All query-protocol could be compatible with previous query.
+2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add argument `Layer`(require). Previous MAL expressions with this function should add this argument.
+3. LAL: [Extractor](../../../docs/en/concepts-and-designs/lal.md) add function `layer`. If don't set it manual, the default layer is `GENERAL` and the logs from `ALS` the
+ default layer is `mesh`.
+4. Storage：Table `ServiceTraffic` add columns `service_id`， `short_name` and `layer`，table `InstanceTraffic` add columns `layer`.
+ These data would be incompatible with previous in some storage, including H2/OpenSearch/MySQL/TiDB/InfluxDB/PostgreSQL.
+ Make sure to remove the older table `ServiceTraffic` and `InstanceTraffic` before OAP(v9) starts.
+ OAP would generate the new table in the start procedure and generate new data when traffic come.
Review comment:
```suggestion
OAP would generate the new table in the start procedure, and recreate all existing services and instances when traffic comes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777867992
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
+
+## Compatibility from previous version
+1. The query-protocol [metadata-v1](https://github.com/apache/skywalking-query-protocol/blob/master/metadata.graphqls) is provided on the top of the v2 implementation.
+ All query-protocol could be compatible with previous query.
+2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add argument `Layer`(require). Previous MAL expressions with this function should add this argument.
+3. LAL: [Extractor](../../../docs/en/concepts-and-designs/lal.md) add function `layer`. If don't set it manual, the default layer is `GENERAL` and the logs from `ALS` the
+ default layer is `mesh`.
+4. Storage：Table `ServiceTraffic` add columns `service_id`， `short_name` and `layer`，table `InstanceTraffic` add columns `layer`.
+ These data would be incompatible with previous in some storage, including H2/OpenSearch/MySQL/TiDB/InfluxDB/PostgreSQL.
+ Make sure to remove the older table `ServiceTraffic` and `InstanceTraffic` before OAP(v9) starts.
+ OAP would generate the new table in the start procedure and generate new data when traffic come.
+5. All other metrics are compatible with previous data format.
Review comment:
```suggestion
5. All other metrics are compatible with the previous data format, so you wouldn't lose metrics.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777867092
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
+
+## Compatibility from previous version
+1. The query-protocol [metadata-v1](https://github.com/apache/skywalking-query-protocol/blob/master/metadata.graphqls) is provided on the top of the v2 implementation.
+ All query-protocol could be compatible with previous query.
+2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add argument `Layer`(require). Previous MAL expressions with this function should add this argument.
+3. LAL: [Extractor](../../../docs/en/concepts-and-designs/lal.md) add function `layer`. If don't set it manual, the default layer is `GENERAL` and the logs from `ALS` the
+ default layer is `mesh`.
+4. Storage：Table `ServiceTraffic` add columns `service_id`， `short_name` and `layer`，table `InstanceTraffic` add columns `layer`.
Review comment:
```suggestion
4. Storage：add `service_id`， `short_name` and `layer` columns to table `ServiceTraffic`， add `layer` column to table `InstanceTraffic`.
```
Grammar issue. `table can't add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 merged pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wankai123 merged pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777865980
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
Review comment:
```suggestion
The compatibility with previous releases is as below.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777866567
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
+A layer represents an abstract framework in computer science, such as Operating System(OS_LINUX layer),
+Kubernetes(k8s layer). This kind of layer would-be owners of different services/instances detected from different technology.
+The query-protocol [metadata-v2](https://github.com/apache/skywalking-query-protocol/blob/master/metadata-v2.graphqls) has been used.
+The compatibility with previous releases as below.
+
+## Compatibility from previous version
+1. The query-protocol [metadata-v1](https://github.com/apache/skywalking-query-protocol/blob/master/metadata.graphqls) is provided on the top of the v2 implementation.
+ All query-protocol could be compatible with previous query.
+2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add argument `Layer`(require). Previous MAL expressions with this function should add this argument.
Review comment:
```suggestion
2. MAL: [metric level function](../../../docs/en/concepts-and-designs/mal.md) add an required argument `Layer`. Previous MAL expressions should add this argument.
```
I think you can't find MAL script doesn't use this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #8379: Support OAP server v9 Core concept: Layer, backend side
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #8379:
URL: https://github.com/apache/skywalking/pull/8379#discussion_r777865172
##########
File path: docs/en/FAQ/v9-version-upgrade.md
##########
@@ -0,0 +1,18 @@
+# V9 upgrade
+Starting from v9, SkyWalking introduces the new core concept [**Layer**]().
Review comment:
The link missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org