[jira] [Commented] (AIRFLOW-5345) Extract SqlSensor's get_hook functionality to an auxiliary function

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918500#comment-16918500 ] 

ASF GitHub Bot commented on AIRFLOW-5345:
-----------------------------------------

gmaliar commented on pull request #5946: [AIRFLOW-5345] Extract SqlSensor get_hook functionality
URL: https://github.com/apache/airflow/pull/5946
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   Due to security reasons we have an alternative PostgreSQL hook that fetches credentials dynamically.
   
   We would still like to use the `SqlSensor` functionality as is as our hook is still backed by sqlalchemy.
   
   By extracting SqlSensor's `connection.get_hook` into a method we can override the `_get_hook` method without affecting the functionality of the hook.
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No functionality changed, rather than just extracted to an auxiliary function. 
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Extract SqlSensor's get_hook functionality to an auxiliary function
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-5345
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5345
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.4
>            Reporter: Guy
>            Assignee: Guy
>            Priority: Minor
>
> Due to security reasons we have an alternative PostgreSQL hook that fetches credentials dynamically.
> We would still like to use the SqlSensor functionality as is as our hook is still backed by sqlalchemy.
> By extracting SqlSensor's get_hook into a method we can override the _get_hook method without affecting the functionality of the hook.
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)