You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Pavel Yaskevich (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/01/25 10:22:40 UTC
[jira] [Issue Comment Edited] (CASSANDRA-3559) CFMetaData
conversions to Thrift/Avro should probably be inverse one of the other
[ https://issues.apache.org/jira/browse/CASSANDRA-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192948#comment-13192948 ]
Pavel Yaskevich edited comment on CASSANDRA-3559 at 1/25/12 9:21 AM:
---------------------------------------------------------------------
Now when CASSANDRA-1391 is committed we can skip Avro validation and concentrate on thrift part because toAvro() methods were removed and fromAvro() methods were marked as @Deprecated so there is no requirement to change them ever again.
was (Author: xedin):
Now when CASSANDRA-1391 is committed we can close this issue because toAvro() methods were removed and fromAvro() methods were marked as @Deprecated so there is no requirement to change them ever again.
> CFMetaData conversions to Thrift/Avro should probably be inverse one of the other
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-3559
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3559
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Labels: avro, thrift
> Fix For: 1.1
>
> Attachments: 3559.patch
>
>
> In other word, it would probably be a idea to have:
> {noformat}
> cfm == CFMetadata.fromThrift(cfm.toThrift())
> cfm == CFMetadata.fromAvro(cfm.toAvro())
> {noformat}
> In particular, we could have unit tests to check that, which would avoid things like CASSANDRA-3558.
> It is not the case today for thrift because of the keyAlias. For some reason, if the keyAlias is not set, we return with toThrift() the default alias. I don't think this serves any purpose though.
> The goal of this ticket is to both fix that (unless there is a compelling reason not to) and add unit tests for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira