You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/03 10:30:50 UTC
[GitHub] [cordova-plugin-whitelist] erisu opened a new pull request #59: breaking: deprecate plugin
erisu opened a new pull request #59:
URL: https://github.com/apache/cordova-plugin-whitelist/pull/59
### Platforms affected
Android
### Motivation, Context & Description
This plugin, which only supports Android, is being integrated into the core of the Cordova Android platform.
https://github.com/apache/cordova-android/pull/1138
This plugin will no longer be required in the next major release of Cordova Android, if the PR is merged in before release.
### Checklist
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-whitelist] jcesarmobile commented on a change in pull request #59: breaking: deprecate plugin
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on a change in pull request #59:
URL: https://github.com/apache/cordova-plugin-whitelist/pull/59#discussion_r621214635
##########
File path: package.json
##########
@@ -26,7 +26,8 @@
"cordova-android": ">=4.0.0"
},
"2.0.0": {
- "cordova": ">100"
+ "cordova": ">100",
Review comment:
What the `"cordova": ">100"` does is to prevent the install of the plugin in case we do a major release and forget to adjust the engines properly, as it will prevent the install, we will notice and update the engines in a new patch release.
What we usually do is to move it to the next major, in this case 3.0.0, but considering that 2.0.0 will be the last one, this line can just be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-whitelist] erisu merged pull request #59: breaking: deprecate plugin
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #59:
URL: https://github.com/apache/cordova-plugin-whitelist/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org