[GitHub] [iceberg] xuzhiwen1255 commented on a diff in pull request #5642: Flink: Fixed an issue where Flink batch entry was not accurate

[GitBox <gi...@apache.org>]

xuzhiwen1255 commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r959197838


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java:
##########
@@ -87,6 +89,7 @@ public void endInput() throws IOException {
     // remaining completed files to downstream before closing the writer so that we won't miss any
     // of them.
     flush();
+    ended = true;

Review Comment:
   > nit: I think we probably don't need this boolean flag. Instead, we can mark writer as null after `writer.complete()`. then we can just use the null check on writer inside the `flush()` method.
   
   Can you add an isclosed method to write to determine whether it has been closed
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org