You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/15 03:10:10 UTC
[GitHub] [arrow] kou opened a new pull request, #12895: ARROW-16070: [C++][Filesystem][S3] Add missing empty content for creating directory
kou opened a new pull request, #12895:
URL: https://github.com/apache/arrow/pull/12895
We can't omit body to create a directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12895: ARROW-16070: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099811223
Revision: 8ef2807ac87fdb830cf26998fd4bfa80998ff3a6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1863](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1863)
|Task|Status|
|----|------|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1863-github-homebrew-r-brew)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12895: ARROW-16070: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099809146
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099863197
Ah, ok, right. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12895: ARROW-16070: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099809130
https://issues.apache.org/jira/browse/ARROW-16070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
URL: https://github.com/apache/arrow/pull/12895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
kou commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1100376890
I'll merge this for green CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1100676491
Benchmark runs are scheduled for baseline = 6f84badd96591c89411c6d1f65be86a708ac2146 and contender = c03b6eb1cb167cceb5aec850bb233ffaa1e0ce14. c03b6eb1cb167cceb5aec850bb233ffaa1e0ce14 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5085bc52e4564a9fa77b318f8edff283...702282dc0f25490eb2ba749be9eee54b/)
[Finished :arrow_down:1.8% :arrow_up:0.17%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3b9456485feb42559e4c852761bb1654...068ef6bab0584a82936f42f6c4898cb6/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cc0c023955fd470c94a6a6ca61f65493...6995bafdd3ef4ff3acfafec124872b03/)
[Finished :arrow_down:0.26% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/98613a0210f44adbaba7246ec3e096fd...6bfcaf43f12d403b8395776df38da448/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/521| `c03b6eb1` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/508| `c03b6eb1` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/507| `c03b6eb1` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/518| `c03b6eb1` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/520| `6f84badd` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/507| `6f84badd` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/506| `6f84badd` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/517| `6f84badd` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099856247
I may have misunderstood. I was looking at this (emphasis added):
> The base64-encoded 128-bit MD5 digest of the message (without the headers) according to RFC 1864. This header can be used as a message integrity check to verify that the data is the same data that was originally sent. **Although it is optional**, we recommend using the Content-MD5 mechanism as an end-to-end integrity check. For more information about REST request authentication, see [REST Authentication](https://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099849207
https://issues.apache.org/jira/browse/ARROW-16043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
kou commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099852467
Sorry. I describe this problem.
Recent AWS SDK for C++ adds checksum automatically by
https://github.com/aws/aws-sdk-cpp/commit/01e61b3137f90509e71765ee7e3b4a39e2e8de91 . The checksum is calculated by request body. If request body is `nullptr`, this problem is occurred.
Each request type knows whether checksum is needed or not. We use `PutObjectRequest` for creating a directory. And it requires `md5` checksum by default by https://github.com/aws/aws-sdk-cpp/commit/24b3cc68451c80a96fbbe133921273b07151d453 .
> the [docs](https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html) do say this should be optional, so I wonder why this became required in the SDK.
Could you quote the sentence for it? I couldn't find it in the docs...
We may report this as a bug to ASW SDK for C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12895: ARROW-16043: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
kou commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099862034
Thanks!
It seems that the docs says checksum is optional but doesn't say anything whether body is optional or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12895: ARROW-16070: [C++][Filesystem][S3] Add missing empty content for creating directory
Posted by GitBox <gi...@apache.org>.
kou commented on PR #12895:
URL: https://github.com/apache/arrow/pull/12895#issuecomment-1099810639
@github-actions crossbow submit homebrew-r-brew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org