You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2014/10/09 23:57:49 UTC

[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28

    CB-7754 - [Geolocation] Support Background Location tracking

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-plugin-geolocation CB-7754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 8e2d0728a477ce6a4b0b2aa70d38322aa40d8ee9
Author: Shazron Abdullah <sh...@apache.org>
Date:   2014-10-09T21:56:34Z

    CB-7754 - [Geolocation] Support Background Location tracking

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by sandstrom <gi...@git.apache.org>.
Github user sandstrom commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-78448058
  
    Any existing value for `NSLocationAlwaysUsageDescription ` in the plist gets overwritten with an empty string. This makes it harder to provide a custom description (which is the purpose of the string, btw).
    
    Don't know if the plugin facility allows, but if it could handle this 'softly', e.g. only add the key to the plist unless it already exists, that would solve it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by Zorgatone <gi...@git.apache.org>.
Github user Zorgatone commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-141024728
  
    Any news about this? Is the issue only about iOS? Does it work in background with other platforms?
    
    Can I use background location on the available platforms with this plugin (with iOS fix)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation issue #28: CB-7754 - [Geolocation] Support Backgr...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/28
  
    @kamendo You'll just have to download the plugin and install it by folder path for now. Cordova@7 dropped support for sub-folders and the plugin has to be migrated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-58585067
  
    Adding it to this repo because it logically belongs here. Either here, or the cordova-plugins repo.
    I would not expect this sub-plugin to be "released" like the other plugins since it will never change, but installable by git url in the meantime:
    
    ```cordova plugin add https://github.com/apache/cordova-plugin-geolocation.git#master:src/ios/background-location ```
    
    We could release it **once** and that's all that is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation issue #28: CB-7754 - [Geolocation] Support Backgr...

Posted by kamendo <gi...@git.apache.org>.
Github user kamendo commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/28
  
    @shazron, just FYI - I ended up adding a custom plugin and swizzle the iOS method in order to get the location working in background :)
    
     https://github.com/stefanminch/background-location-app/blob/master/src/ios/BackgroundProcess.m


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation issue #28: CB-7754 - [Geolocation] Support Backgr...

Posted by kamendo <gi...@git.apache.org>.
Github user kamendo commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/28
  
    I tried
    
    > cordova plugin add https://github.com/apache/cordova-plugin-geolocation.git#master:src/ios/background-location
    
    but failed with this error:
    'support for subdirectories is deprecated and will be removed in Cordova@7
    Error: --fetch does not support subdirectories'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-74966028
  
    The plugin supports geolocation tracking on iOS 8 only when the app is in use. To use it when the app is in the background, you need to install the plugin above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-169124917
  
    iOS only. See the issue in JIRA : https://issues.apache.org/jira/browse/CB-7754


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by MrMotski <gi...@git.apache.org>.
Github user MrMotski commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-167848233
  
    Is there any update to @Zorgatone's question? I'm also very interested to know the answer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation pull request: CB-7754 - [Geolocation] S...

Posted by michaelkrog <gi...@git.apache.org>.
Github user michaelkrog commented on the pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-74481492
  
    @shazron can you helpt me out? 
    
    I'm a bit confused. Does cordova-plugin-geolocation currently have background location support or does it not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-geolocation issue #28: CB-7754 - [Geolocation] Support Backgr...

Posted by diegobill <gi...@git.apache.org>.
Github user diegobill commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/28
  
    +1
    
    I'm also very interested in Android and iOS support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org