You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/18 21:10:06 UTC
[GitHub] [cordova-android] ath0mas opened a new pull request #1213: Review `create` default values and stop project name transform
ath0mas opened a new pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Mixed default values for `create` between cli doc, cordova-android and cordova-ios.
And wrong project name if with spaces and accents: see #1210
### Description
<!-- Describe your changes in detail -->
Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:
- **id** / package name: `io.cordova.helloCordova`
- **name** / project name: `Hello Cordova`
See linked PRs: apache/cordova-cli#554, apache/cordova-ios#1100
And
- Fix #1210: project name not transformed anymore (was replacing non-word characters with underscores), because there is no known limitation with it, project creation and all still work fine, and cordova-ios does it the same way
- small update on main Readme to update/add details for use and test
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm test` success + project creation, open and run from IDE into emulator
Fine on 10.0.0-dev and same for 9.2.0-dev 👍 (would be nice to backport this into a 9.x fix release)
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r681288410
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
+
+To use a **shared CordovaLib**, for example in development, link the appropriate cordova-android platform folder path:
Review comment:
Changes on Readme moved to PR #1308 ; and I now use `framework` as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#issuecomment-822062425
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9c165cb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1213 +/- ##
=========================================
Coverage ? 71.98%
=========================================
Files ? 21
Lines ? 1692
Branches ? 0
=========================================
Hits ? 1218
Misses ? 474
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.19% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c165cb...7ad4fe7](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r680968229
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
Review comment:
Eventhough this `version` script still exists, it most likely to be removed in the future.
The reason why the script still exists today, is because the CLI command `cordova platforms` calls this script to disiplay the installed platform version.
In the future, the CLI will just call directly to the platform's API to return the version.
If you decide to exclude adding this, then the entire section is no longer needed so you can also remove the opening:
> These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1213: feat: unify `create` default values & stop project name transform
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r681288023
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
Review comment:
Changes on Readme moved to PR #1308 ; and I removed this block from my commits
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
Review comment:
Changes on Readme moved to PR #1308 ; and I removed this block from my commits
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
Review comment:
Changes on Readme moved to PR #1308 ; and I removed this block from my commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r681071698
##########
File path: lib/create.js
##########
@@ -229,7 +228,7 @@ exports.create = function (project_path, config, options, events) {
.then(function () {
return exports.validateProjectName(project_name);
}).then(function () {
- // Log the given values for the project
+ // Log the given values for the project
Review comment:
OK ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r680965535
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
Review comment:
These scripts have been removed. We are no longer supporting this process.
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
+
+To use a **shared CordovaLib**, for example in development, link the appropriate cordova-android platform folder path:
Review comment:
I am not sure about using the wording `CordovaLib` in this case.
I know you said you copied from iOS, but in the iOS repo, the native's framework is called `CordovaLib`. You can even see the `CordovaLib` directory. Android calls it `framework`.
`CordovaLib` can also be confusing for some people cause we have a `cordova-lib` repo which is used in the CLI.
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
+
+To use a **shared CordovaLib**, for example in development, link the appropriate cordova-android platform folder path:
+
+```bash
+cordova platform add --link /path/to/cordova-android
+```
+
## Using Android Studio
1. Create a project
2. Import it via "Non-Android Studio Project"
-## Running the Native Tests
+## Updating a Cordova project
+
+When you install a new `cordova-cli` version that comes with a new Android platform version, from within your project:
+
+```bash
+cordova platform rm android
+cordova platform add android
+```
+
+## How to Test Repo Development
+
+```bash
+npm install
+npm test
+```
+
+## Futher reading
-The `test/` directory in this project contains an Android test project that can be used to run different kinds of native tests. Check out the [README contained therein](test/README.md) for more details!
+* [https://cordova.apache.org/](https://cordova.apache.org/)
Review comment:
```suggestion
* [Apache Cordova](https://cordova.apache.org/)
```
##########
File path: lib/create.js
##########
@@ -229,7 +228,7 @@ exports.create = function (project_path, config, options, events) {
.then(function () {
return exports.validateProjectName(project_name);
}).then(function () {
- // Log the given values for the project
+ // Log the given values for the project
Review comment:
Generally, I would suggest adding a seperate chore/style PR for these type of changes, but since you are only formatting one line, I guess it is OK ><.
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
Review comment:
These scripts have been removed. We are no longer supporting this process.
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
Review comment:
Eventhough this script still exists, it most likely will be removed in the future.
The reason why the script still exists today, is because the CLI command `cordova platforms` calls this script to disiplay the installed platform version.
In the future, the CLI will just call directly to the platform's API to return the version.
If you decide to exclude adding this, then the entire section is no longer needed so you can also remove the opening:
> These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#issuecomment-822062425
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9c165cb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1213 +/- ##
=========================================
Coverage ? 71.98%
=========================================
Files ? 21
Lines ? 1692
Branches ? 0
=========================================
Hits ? 1218
Misses ? 474
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.19% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c165cb...7ad4fe7](https://codecov.io/gh/apache/cordova-android/pull/1213?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#issuecomment-890484183
I rebased this PR
Can you please go back to it, and same for the 2 linked PRs (apache/cordova-cli#554, apache/cordova-ios#1100) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on a change in pull request #1213: Review `create` default values and stop project name transform
Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1213:
URL: https://github.com/apache/cordova-android/pull/1213#discussion_r681288632
##########
File path: README.md
##########
@@ -32,18 +32,54 @@ Cordova Android is an Android application library that allows for Cordova-based
## Requirements
-- Java Development Kit (JDK) 11
-- [Android SDK](https://developer.android.com/)
+* Java Development Kit (JDK) 11
+* [Android SDK](https://developer.android.com/)
## Cordova Android Developer Tools
Use the [Cordova command-line tool](https://www.npmjs.com/package/cordova) to create projects and install plugins.
+However, the following scripts can be used instead:
+
+ ./bin/create [path package activity] ... creates the ./example app or a cordova android project
+ ./bin/check_reqs ....................... checks that your environment is set up for cordova-android development
+ ./bin/update [path] .................... updates an existing cordova-android project to the version of the framework
+
+These commands live in a generated Cordova Android project. Any interactions with the emulator require you to have an AVD defined.
+
+ ./cordova/clean ........................ cleans the project
+ ./cordova/build ........................ calls `clean` then compiles the project
+ ./cordova/log ........................ streams device or emulator logs to STDOUT
+ ./cordova/run ........................ calls `build` then deploys to a connected Android device. If no Android device is detected, will launch an emulator and deploy to it.
+ ./cordova/version ...................... returns the cordova-android version of the current project
+
+To use a **shared CordovaLib**, for example in development, link the appropriate cordova-android platform folder path:
+
+```bash
+cordova platform add --link /path/to/cordova-android
+```
+
## Using Android Studio
1. Create a project
2. Import it via "Non-Android Studio Project"
-## Running the Native Tests
+## Updating a Cordova project
+
+When you install a new `cordova-cli` version that comes with a new Android platform version, from within your project:
+
+```bash
+cordova platform rm android
+cordova platform add android
+```
+
+## How to Test Repo Development
+
+```bash
+npm install
+npm test
+```
+
+## Futher reading
-The `test/` directory in this project contains an Android test project that can be used to run different kinds of native tests. Check out the [README contained therein](test/README.md) for more details!
+* [https://cordova.apache.org/](https://cordova.apache.org/)
Review comment:
Changes on Readme moved to PR #1308 ; and I commited this suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org