You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/27 15:20:32 UTC

[GitHub] [arrow] n3world commented on a change in pull request #10794: ARROW-13441: [C++][CSV] Skip empty batches in column decoder

n3world commented on a change in pull request #10794:
URL: https://github.com/apache/arrow/pull/10794#discussion_r677556221



##########
File path: cpp/src/arrow/csv/column_decoder.cc
##########
@@ -198,6 +198,11 @@ Result<std::shared_ptr<Array>> InferringColumnDecoder::RunInference(
 
 Future<std::shared_ptr<Array>> InferringColumnDecoder::Decode(
     const std::shared_ptr<BlockParser>& parser) {
+  if (parser->num_rows() == 0) {

Review comment:
       I think I'll keep empty array because as you point out nullptr usually indicates EOF and to avoid any dereference issues from the downstream converters which assume no nulls.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org