You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/09 18:40:45 UTC
[GitHub] [tvm] tkonolige opened a new pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
tkonolige opened a new pull request #10552:
URL: https://github.com/apache/tvm/pull/10552
Ignore these files so they are not accidentally committed.
@kparzysz-quic @adstraw @csullivan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #10552:
URL: https://github.com/apache/tvm/pull/10552#issuecomment-1064248426
@Lunderberg I do not think this excludes the files from the lint. A better solution may be to make sure that these files are not generated in tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10552:
URL: https://github.com/apache/tvm/pull/10552#issuecomment-1064312309
Hmm, looks like it would be a trickier update. It's pretty easy to change to output to write to the build directory, but hunting down the different include locations for the generated `hexagon_rpc.h` would take more investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10552:
URL: https://github.com/apache/tvm/pull/10552#issuecomment-1064277550
Good point. I'll poke around a bit at `Hexagon.cmake` and see if it causes issues to generate the files in the build dir instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on pull request #10552:
URL: https://github.com/apache/tvm/pull/10552#issuecomment-1064314975
I'll look into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg merged pull request #10552: [FIX,HEXAGON] Gitignore generated Hexagon files
Posted by GitBox <gi...@apache.org>.
Lunderberg merged pull request #10552:
URL: https://github.com/apache/tvm/pull/10552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org