[jira] [Commented] (OOZIE-2867) Timezone handling for Coordinators: emphasize "Continent/City" format

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227195#comment-16227195 ] 

Hadoop QA commented on OOZIE-2867:
----------------------------------

Testing JIRA OOZIE-2867

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
.    {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 2049
.    Tests failed: 8
.    Tests errors: 2

.    The patch failed the following testcases:

.      testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.      testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.      testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.      testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.      testImportTablesOverflowBatchSize(org.apache.oozie.tools.TestDBLoadDump)
.      testImportInvalidDataLeavesTablesEmpty(org.apache.oozie.tools.TestDBLoadDump)
.      testImportToNonEmptyTablesCausesPrematureExit(org.apache.oozie.tools.TestDBLoadDump)
.      testImportedDBIsExportedCorrectly(org.apache.oozie.tools.TestDBLoadDump)

.    Tests failing with errors:
.      testAddXIncludeFromReader(org.apache.oozie.util.TestXConfiguration)
.      testAddXIncludeFromStream(org.apache.oozie.util.TestXConfiguration)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/156/

> Timezone handling for Coordinators: emphasize "Continent/City" format
> ---------------------------------------------------------------------
>
>                 Key: OOZIE-2867
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2867
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: coordinator
>    Affects Versions: 4.3.0
>            Reporter: Andras Piros
>            Assignee: Artem Ervits
>         Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch, OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch, OOZIE-2867-5.patch, OOZIE-2867-6.patch, OOZIE-2867-7.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer Time silently just do not get accepted correctly by Oozie and the underlying JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to only use time zone format {{Continent/City}}, like {{Europe/London}}, or {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}} log and suppose {{UTC}} instead of silently ignoring the unknown specified timezone



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)