You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Tim Moloney (JIRA)" <ji...@apache.org> on 2007/03/07 09:13:24 UTC

[jira] Created: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
-------------------------------------------------------------------------------------------------

                 Key: FELIX-247
                 URL: https://issues.apache.org/jira/browse/FELIX-247
             Project: Felix
          Issue Type: New Feature
          Components: Maven Plugin
            Reporter: Tim Moloney
            Priority: Minor




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488864 ] 

Tim Moloney commented on FELIX-247:
-----------------------------------

I made the assumption that what was in the trunk of the ant plugin repository would be in the next release of the ant plugin.

Perhaps I'm misunderstanding the code but line 564 of http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-ant-plugin/src/main/java/org/apache/maven/plugin/ant/AntBuildWriterUtil.java appears to allow customizing the manifest attribute in the jar task.


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488845 ] 

Carlos Sanchez commented on FELIX-247:
--------------------------------------

I'm looking at the ant plugin sources and i don't see anything that indicates it's going to be fixed in next releases, and I haven't found any jira in http://jira.codehaus.org/browse/MANT

If you can provide a patch against the current sources we can make a release really soon, for what I see it'll require refactoring to remove too many static methods

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488869 ] 

Carlos Sanchez commented on FELIX-247:
--------------------------------------

ok, i got it. I was confused by the patch that seems to be copied from an old version of the plugin and all the static methods that prevent extension

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478976 ] 

Tim Moloney commented on FELIX-247:
-----------------------------------

One change required to build.xml is to point the maven.repo.local property at a directory that has all the dependency jars.  Simply change the value attribute in the following line to the name of the appropriate directory.

<property name="maven.repo.local" value="${user.home}/.m2/repository"/>


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Moloney updated FELIX-247:
------------------------------

    Description: 
Modify maven-bundle-plugin so that runing

  mvn org.apache.felix:maven-bundle-plugin:ant

creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).

The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488846 ] 

Carlos Sanchez commented on FELIX-247:
--------------------------------------

http://jira.codehaus.org/browse/MANT-29

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488833 ] 

Tim Moloney commented on FELIX-247:
-----------------------------------

Yes, but ...

http://www.mail-archive.com/felix-dev@incubator.apache.org/msg04672.html


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by Tim Moloney <t....@verizon.net>.
Thanks for initiating the vote and keeping this list informed.


Carlos Sanchez (JIRA) wrote:
>     [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491357 ] 
>
> Carlos Sanchez commented on FELIX-247:
> --------------------------------------
>
> the release of the ant plugin is being voted
> http://www.nabble.com/-VOTE--Release-maven-ant-plugin-2.0-tf3576676s177.html
>
>   
>> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
>> -------------------------------------------------------------------------------------------------
>>
>>                 Key: FELIX-247
>>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>>             Project: Felix
>>          Issue Type: New Feature
>>          Components: Maven Bundle Plugin
>>            Reporter: Tim Moloney
>>            Priority: Minor
>>         Attachments: maven-bundle-plugin-ant-1.patch
>>
>>
>> Modify maven-bundle-plugin so that runing
>>   mvn org.apache.felix:maven-bundle-plugin:ant
>> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
>> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.
>>     
>
>   


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491357 ] 

Carlos Sanchez commented on FELIX-247:
--------------------------------------

the release of the ant plugin is being voted
http://www.nabble.com/-VOTE--Release-maven-ant-plugin-2.0-tf3576676s177.html

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Moloney updated FELIX-247:
------------------------------

    Attachment: maven-bundle-plugin-ant-1.patch

This patch adds the ant goal as specified.

Although it appears to be a big patch, functionally it is very simple.

This patch
- moves most of the functionality in BundlePlugin.java to BundleProperties.java so it call be accessed by mulitple MOJOs
- moves the remaining functionality in BundlePlugin.java to PackageMojo.java for consistent naming
- adds AntMojo.java to create the build.xml and MANIFEST.MF files
- adds a slightly modified AntBuildWriter.java from maven-ant-plugin since it currently isn't extensible.


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Carlos Sanchez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488720 ] 

Carlos Sanchez commented on FELIX-247:
--------------------------------------

this sounds like repeating a lot of what the Ant plugin already does
http://maven.apache.org/plugins/maven-ant-plugin/

> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478717 ] 

Tim Moloney commented on FELIX-247:
-----------------------------------

This issue is a step towards implementing the capability discussed in this mail thread.

http://www.mail-archive.com/felix-dev@incubator.apache.org/msg02728.html


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-247) Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers

Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488892 ] 

Tim Moloney commented on FELIX-247:
-----------------------------------

Okay, I understand the confusion.

The patch *is* a slightly modified copy of the currently released ant file.  I did this since it is more self-contained and convenient.  People who want to use this patch can just apply it to Felix rather than having to download and build the latest version of the ant plugin.  Hopefully, the next release version of the ant plugin will allow us to set a property so we don't have to do this ugly kludge.

As was stated in the email thread, I'm not in a hurry.  This issue can be left open until we can implement it properly with the (hopefully) next release of the ant plugin.  I'm perfectly okay with that.  :)


> Add ant goal to maven-bundle-plugin which creates a build.xml and MANIFEST.MF with bundle headers
> -------------------------------------------------------------------------------------------------
>
>                 Key: FELIX-247
>                 URL: https://issues.apache.org/jira/browse/FELIX-247
>             Project: Felix
>          Issue Type: New Feature
>          Components: Maven Bundle Plugin
>            Reporter: Tim Moloney
>            Priority: Minor
>         Attachments: maven-bundle-plugin-ant-1.patch
>
>
> Modify maven-bundle-plugin so that runing
>   mvn org.apache.felix:maven-bundle-plugin:ant
> creates the build.xml and MANIFEST.MF files for the current source code.  This allows a working bundle to be created from a source distribution using ant (without using maven).
> The goal of this issue is not to allow development using ant but to provide a way of distributing source code that uses ant to build a working bundle.  Any changes to the source code that affect the bundle headers would not be updated in the manifest, since the manifest file is created at the same time as the build file and is not changed by any ant task.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.