You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/18 23:59:33 UTC

[GitHub] [beam] rohdesamuel commented on a change in pull request #12415: [BEAM-10603] Add the RecordingManager and associated classes.

rohdesamuel commented on a change in pull request #12415:
URL: https://github.com/apache/beam/pull/12415#discussion_r472558013



##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner.py
##########
@@ -152,7 +152,11 @@ def run_pipeline(self, pipeline, options):
               user_pipeline)):
         streaming_cache_manager = ie.current_env().get_cache_manager(
             user_pipeline)
-        if streaming_cache_manager:
+
+        # Only make the server if it doens't exist already.
+        if (streaming_cache_manager and
+            not ie.current_env().get_test_stream_service_controller(

Review comment:
       No, the server is "one-time" use. Once it stops it can't be started up again and this should be set None.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org