You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/09/11 11:07:08 UTC

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24821


Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

WIP: Generate HiveServer2 (TCLIService) Java in Impala

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 39 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG@11
PS7, Line 11: Impala) inheriting from TCLIService (coming from Hive). Add
> nit: capitalization is inconsistent.
Done


http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml@1077
PS7, Line 1077:               <artifactId>hive-service-rpc</artifactId>
> Should we add a rule to maven-enforcer-plugin?
It seems that it is not that easy, because the version pinning rule's include rule: <include>org.apache.hive:*:${hive.version}</include>

Create a patch to separate version/artifact exclusion, with that it would be easy to add such rule:
https://gerrit.cloudera.org/#/c/24846/

I didn't want to do that change in this patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 09:14:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 10: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14051/


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 15:47:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 22:43:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24050/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 16:27:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24821/7//COMMIT_MSG@11
PS7, Line 11: Impala) inheriting from TCliService (coming from Hive). Add
nit: capitalization is inconsistent.


http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml@1077
PS7, Line 1077:               <artifactId>hive-service-rpc</artifactId>
Should we add a rule to maven-enforcer-plugin?



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Sep 2026 21:05:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 10:14:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14022/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 18:41:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23996/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 19:11:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#7).

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCliService (coming from Hive). Add
generation of TCliService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 37 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/7
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#8).

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCLIService (coming from Hive). Add
generation of TCLIService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 37 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/8
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCLIService (coming from Hive). Add
generation of TCLIService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
Reviewed-on: http://gerrit.cloudera.org:8080/24821
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 54 insertions(+), 7 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 13
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] WIP IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24014/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Sep 2026 15:38:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14014/


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 15:43:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24821/8/common/thrift/CMakeLists.txt
File common/thrift/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/24821/8/common/thrift/CMakeLists.txt@107
PS8, Line 107: unnecessary __init__.py
What problem it causes?



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 15:25:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12:

it turned out that yet another exclusion is needed for hive2
rerunning the build


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 18:19:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 18:27:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#10).

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCLIService (coming from Hive). Add
generation of TCLIService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 39 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/10
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24017/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Sep 2026 20:10:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24821/8/common/thrift/CMakeLists.txt
File common/thrift/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/24821/8/common/thrift/CMakeLists.txt@107
PS8, Line 107: unnecessary __init__.py
> What problem it causes?
I don't know. This was copied from the prev block (see line 88)



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 19:32:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 10:

(1 comment)

ps9 is just rebase (including changes around maven-enforcer-plugin), ps10 adds a rule to exclude org.apache.hive:hive-service-rpc

http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml
File fe/pom.xml:

http://gerrit.cloudera.org:8080/#/c/24821/7/fe/pom.xml@1077
PS7, Line 1077:               <artifactId>*</artifactId>
> It seems that it is not that easy, because the version pinning rule's inclu
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 09:51:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14053/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 16:08:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#12).

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCLIService (coming from Hive). Add
generation of TCLIService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 54 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/12
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#5).

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

WIP: Generate HiveServer2 (TCLIService) Java in Impala

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
M common/thrift/CMakeLists.txt
M common/thrift/hive-1-api/TCLIService.thrift
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
4 files changed, 71 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/5
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 10: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 11:02:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14051/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 10
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 11:07:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/23995/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 18:52:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14023/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 18:50:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23979/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 11:31:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 23:16:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Sep 2026 14:26:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#6).

Change subject: WIP IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

WIP IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCliService (coming from Hive). Add
generation of these classes in Impala and exclude the ones from
Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M common/thrift/hive-1-api/TCLIService.thrift
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
4 files changed, 42 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/6
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 18:22:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14057/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 18:18:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 12:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24057/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 18:45:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#3).

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

WIP: Generate HiveServer2 (TCLIService) Java in Impala

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
M common/thrift/CMakeLists.txt
M common/thrift/hive-1-api/TCLIService.thrift
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
4 files changed, 70 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24821/3/common/thrift/hive-1-api/TCLIService.thrift
File common/thrift/hive-1-api/TCLIService.thrift:

http://gerrit.cloudera.org:8080/#/c/24821/3/common/thrift/hive-1-api/TCLIService.thrift@98
PS3, Line 98:   UNKNOWN_TYPE
Enum item TIMESTAMPLOCALTZ_TYPE=22 changed to UNKNOWN_TYPE=22 in TTypeId. This might break the compatibility between impalad and catalogd/statestore during upgrade



-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 18:43:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: WIP: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14014/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2026 11:07:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 11: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 17:54:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24821

to look at the new patch set (#11).

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................

IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

The goal is the remove the heavy coupling between Impala and
Hive Thrift version caused by ImpalaServices (generated by
Impala) inheriting from TCLIService (coming from Hive). Add
generation of TCLIService classes in Impala and exclude the
ones from Hive.

Note that this does not affect classes coming from Hive metastore -
those are in the same namespace, but inherited from
hive-standalone-metastore instead of hive-jdbc +
impala-minimal-hive-exec.

Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Assisted-By: Claude Opus 4.8
---
M common/thrift/CMakeLists.txt
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
3 files changed, 46 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/24821/11
-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24821 )

Change subject: IMPALA-15349: Generate HiveServer2 (TCLIService) Java in Impala
......................................................................


Patch Set 11: Code-Review+2

It turned out that Hive 2 profile needs an additional exclusion. Carrying +2 as this is a minimal change.


-- 
To view, visit http://gerrit.cloudera.org:8080/24821
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9882ec486e62bda1177d0b678e4543683e3cf6b2
Gerrit-Change-Number: 24821
Gerrit-PatchSet: 11
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Sep 2026 16:07:50 +0000
Gerrit-HasComments: No