You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/23 18:39:16 UTC

[GitHub] [helix] jiminoc opened a new issue #906: Helix Agent doc examples not parsing command line parameters correctly

jiminoc opened a new issue #906: Helix Agent doc examples not parsing command line parameters correctly
URL: https://github.com/apache/helix/issues/906
 
 
   I tried following the tutorial here: 
   https://helix.apache.org/0.9.4-docs/tutorial_agent.html
   
   specifically when I tried to add state changes listed below
   `./helix-admin.sh --zkSvr 10.148.110.208:2181 --setConfig CLUSTER LIVENESS ONLINE-SLAVE.command="simpleHttpClient.py ONLINE-SLAVE"`
   
   when I look in the Helix Admin UI, the configuration section only shows
   `simpleHttpClient.py`
   
   as the parameter for _ONLINE-SLAVE.command_
   
   I went into the method:
   `parseCsvFormatedKeyValuePairs`
   
   in _HelixUtil.java_
   
   and changed
   
   `String[] pairs = keyValuePairs.split("[\\s,]");`
   
   to 
   
   `String[] pairs = keyValuePairs.split(",");`
   
   and it works correcly. When I rebuild and run again with that change and look in Helix UI the configuration then shows
   
   `simpleHttpClient.py ONLINE-SLAVE`
   
   and my python example script receives the correct parameters after that. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org