You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 18:31:06 UTC
[GitHub] [arrow-ballista] avantgardnerio opened a new pull request, #475: Add support for Tableau
avantgardnerio opened a new pull request, #475:
URL: https://github.com/apache/arrow-ballista/pull/475
# Which issue does this PR close?
Closes #428.
# Rationale for this change
Explained in the issue.
# What changes are included in this PR?
Added two FlightSQL handlers necessary for Tableau (and most likely others).
# Are there any user-facing changes?
More analytics tools should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #475: Add support for Tableau
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #475:
URL: https://github.com/apache/arrow-ballista/pull/475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #475: Add support for Tableau
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #475:
URL: https://github.com/apache/arrow-ballista/pull/475#issuecomment-1295330167
@andygrove I don't know who other than you is tracking FlightSQL support to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #475: Add support for Tableau
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #475:
URL: https://github.com/apache/arrow-ballista/pull/475#discussion_r1008433059
##########
ballista/scheduler/src/flight_sql.rs:
##########
@@ -257,6 +333,11 @@ impl FlightSqlServiceImpl {
fn df_schema_to_arrow(&self, schema: &DFSchemaRef) -> Result<Vec<u8>, Status> {
let arrow_schema: Schema = (&**schema).into();
+ let schema_bytes = self.schema_to_arrow(Arc::new(arrow_schema))?;
+ Ok(schema_bytes)
Review Comment:
looks like it can be simplified to:
```suggestion
self.schema_to_arrow(Arc::new(arrow_schema))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org