You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/10 08:40:22 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
panbingkun opened a new pull request, #42862:
URL: https://github.com/apache/spark/pull/42862
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1712795300
<img width="832" alt="image" src="https://github.com/apache/spark/assets/1475305/b29a3e05-c10d-4da9-9fac-c5f61cb9356e">
Are these bug fixes related to 8.3.2? Spark doesn’t use 8.5.1, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1713178555
also cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716965815
Thank you for reproducing it, @LuciferYang !
It sounds like a bug still because SIGSEGV should not happen even in that abuse use case. We expect some Java-layer Exception like `IllegalStateException`
> This might not be a problem with rocksdb, rather it could be due to some asynchronous operations in the business code leading to accessing a closed rocksdb instance...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716098526
FTW, is it possible to get the core dump and submit an issue to rocksdb/rocksdbjni project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1717084042
> Thank you for reproducing it, @LuciferYang !
>
> It sounds like a bug still because SIGSEGV should not happen even in that abuse use case. We expect some Java-layer Exception like `IllegalStateException`
>
> > This might not be a problem with rocksdb, rather it could be due to some asynchronous operations in the business code leading to accessing a closed rocksdb instance...
Filed an issue on rocksdb: https://github.com/facebook/rocksdb/issues/11825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716805827
Let me investigate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1712802814
<img width="1207" alt="image" src="https://github.com/apache/spark/assets/15246973/eaa2fd67-a776-45d9-99bf-611dd9a16f35">
The bug fixes listed above are release notes from version 8.3.3, which I believe are bug fixes relative to versions before 8.3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1717099988
when I revert version 8.1.1.1, accessing DB while it is closed will still generate the following core messages:
```
15:31:12.496 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x00000001207d0d20, pid=93758, tid=0x0000000000007d03
#
# JRE version: OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (8.0_352-b08) (build 1.8.0_352-b08)
# Java VM: OpenJDK 64-Bit Server VM (25.352-b08 mixed mode bsd-aarch64 compressed oops)
# Problematic frame:
# C [librocksdbjni6268389328305132469.jnilib+0x24d20] Java_org_rocksdb_RocksDB_getProperty+0x58
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/panbingkun/Developer/spark/spark-community/sql/core/hs_err_pid93758.log
#
# If you would like to submit a bug report, please visit:
# http://www.azul.com/support/
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
Warning: Unable to read from client, please check on client for further details of the problem.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716089441
That's too bad. In the worst case, we might consider that too, but I'm not sure.
- Apache Spark 3.4.1 is using `rocksdbjni-7.9.2.jar`.
- Apache Spark 3.5.0 is shipped with `rocksdbjni-8.3.2.jar` already.
Is 8.1.1.1 stable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1715990403
+1 for revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716966458
Thank you, @viirya and @panbingkun , too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42862:
URL: https://github.com/apache/spark/pull/42862#discussion_r1321964162
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -225,7 +225,7 @@ parquet-jackson/1.13.1//parquet-jackson-1.13.1.jar
pickle/1.3//pickle-1.3.jar
py4j/0.10.9.7//py4j-0.10.9.7.jar
remotetea-oncrpc/1.1.2//remotetea-oncrpc-1.1.2.jar
-rocksdbjni/8.3.2//rocksdbjni-8.3.2.jar
+rocksdbjni/8.5.3//rocksdbjni-8.5.3.jar
Review Comment:
Maybe, we need to change the issue type of SPARK-45110. Currently, it's filed as `Improvement` for Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1715155490
Thank you, @panbingkun and all.
Merged to master/3.5 for Apache Spark 3.5.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1712993106
cc @xuanyuanking and @viirya FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
URL: https://github.com/apache/spark/pull/42862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716084118
@dongjoon-hyun @viirya Actually, I have observed several core dumps in version 8.3.2:
https://issues.apache.org/jira/browse/SPARK-44580
```
#
17177# A fatal error has been detected by the Java Runtime Environment:
17178#
17179# SIGSEGV (0xb) at pc=0x00007f8a077d2743, pid=4403, tid=0x00007f89cadff640
17180#
17181# JRE version: OpenJDK Runtime Environment (8.0_372-b07) (build 1.8.0_372-b07)
17182# Java VM: OpenJDK 64-Bit Server VM (25.372-b07 mixed mode linux-amd64 compressed oops)
17183# Problematic frame:
17184# C [librocksdbjni886380103972770161.so+0x3d2743] rocksdb::DBImpl::FailIfCfHasTs(rocksdb::ColumnFamilyHandle const*) const+0x23
17185#
17186# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
17187#
17188# An error report file with more information is saved as:
17189# /home/runner/work/spark/spark/sql/core/hs_err_pid4403.log
17190#
17191# If you would like to submit a bug report, please visit:
17192# https://github.com/adoptium/adoptium-support/issues
17193# The crash happened outside the Java Virtual Machine in native code.
17194# See problematic frame for where to report the bug.
17195#
```
So should we revert to version 8.1.1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #42862:
URL: https://github.com/apache/spark/pull/42862#discussion_r1321961100
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -225,7 +225,7 @@ parquet-jackson/1.13.1//parquet-jackson-1.13.1.jar
pickle/1.3//pickle-1.3.jar
py4j/0.10.9.7//py4j-0.10.9.7.jar
remotetea-oncrpc/1.1.2//remotetea-oncrpc-1.1.2.jar
-rocksdbjni/8.3.2//rocksdbjni-8.3.2.jar
+rocksdbjni/8.5.3//rocksdbjni-8.5.3.jar
Review Comment:
Unfortunately, Apache Spark 3.5.0 RC5 is also using RocksDB 8.3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42862:
URL: https://github.com/apache/spark/pull/42862#discussion_r1322290899
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -225,7 +225,7 @@ parquet-jackson/1.13.1//parquet-jackson-1.13.1.jar
pickle/1.3//pickle-1.3.jar
py4j/0.10.9.7//py4j-0.10.9.7.jar
remotetea-oncrpc/1.1.2//remotetea-oncrpc-1.1.2.jar
-rocksdbjni/8.3.2//rocksdbjni-8.3.2.jar
+rocksdbjni/8.5.3//rocksdbjni-8.5.3.jar
Review Comment:
Done
<img width="659" alt="image" src="https://github.com/apache/spark/assets/15246973/8dbc1822-43e4-4d76-95aa-a7e9f31b4a4f">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716164405
```
# C [librocksdbjni8661574108371776748.so+0x3ef7e7] rocksdb::DBImpl::GetProperty(rocksdb::ColumnFamilyHandle*, rocksdb::Slice const&, std::string*)+0x57
```
I have changed some code and tried to call the getDBProperty method on a closed RocksDB instance, a similar error occurs. This might not be a problem with rocksdb, rather it could be due to some asynchronous operations in the business code leading to accessing a closed instance...
```
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x000000015b8d16b0, pid=23605, tid=26371
#
# JRE version: OpenJDK Runtime Environment Zulu17.44+15-CA (17.0.8+7) (build 17.0.8+7-LTS)
# Java VM: OpenJDK 64-Bit Server VM Zulu17.44+15-CA (17.0.8+7-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, bsd-aarch64)
# Problematic frame:
# C [librocksdbjni15748758312520513152.jnilib+0x1056b0] rocksdb::DBImpl::GetProperty(rocksdb::ColumnFamilyHandle*, rocksdb::Slice const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>*)+0x54
#
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/yangjie01/SourceCode/git/spark-mine-sbt/sql/core/hs_err_pid23605.log
#
# If you would like to submit a bug report, please visit:
# http://www.azul.com/support/
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1715986788
It seems that GitHub Action complains with a segfault from this RocksDB version.
- https://github.com/apache/spark/actions/runs/6156730315/job/16706042686
```
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x00007fc89e1ef7e7, pid=83569, tid=0x00007fc87fffd640
#
# JRE version: OpenJDK Runtime Environment (8.0_382-b05) (build 1.8.0_382-b05)
# Java VM: OpenJDK 64-Bit Server VM (25.382-b05 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C [librocksdbjni8661574108371776748.so+0x3ef7e7] rocksdb::DBImpl::GetProperty(rocksdb::ColumnFamilyHandle*, rocksdb::Slice const&, std::string*)+0x57
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/runner/work/spark/spark/sql/core/hs_err_pid83569.log
Compiled method (nm) 246314 30882 n 0 org.rocksdb.RocksDB::getProperty (native)
total in heap [0x00007fc8fc7af7d0,0x00007fc8fc7afb60] = 912
relocation [0x00007fc8fc7af8f8,0x00007fc8fc7af940] = 72
main code [0x00007fc8fc7af940,0x00007fc8fc7afb58] = 536
oops [0x00007fc8fc7afb58,0x00007fc8fc7afb60] = 8
#
# If you would like to submit a bug report, please visit:
# https://github.com/adoptium/adoptium-support/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
```
Let me revert this RocksDB version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1712789997
Let me add the results of org.apache.spark.sql.execution.benchmark.StateStoreBasicOperationsBenchmark.
JDK8: https://github.com/panbingkun/spark/actions/runs/6136869653
JDK11: https://github.com/panbingkun/spark/actions/runs/6136872945
JDK17: https://github.com/panbingkun/spark/actions/runs/6136874414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1715992174
This is reverted.
- master: https://github.com/apache/spark/commit/f33c2051c01eb09f6bbb602ed3c7c637e1c6f421
- branch-3.5: https://github.com/apache/spark/commit/6a2284feaac4f632d645a93361d29e693eeb9d32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716096252
At least, I haven't observed any core dump cases in 8.1.1.1. On the other hand, I'm conducting targeted r/w stress tests on version 8.1.1.1. It will take a few days before I can reach further conclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42862: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.5.3
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42862:
URL: https://github.com/apache/spark/pull/42862#issuecomment-1716107530
It seems the problem always occurs in `RocksDBStateStoreStreamingAggregationSuite`? but I have not reproduced the core dump locally. Do we have the authority to execute ‘ulimit -c unlimited’? I’m not too clear on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org