You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2018/10/28 10:26:37 UTC

[GitHub] FlorianHockmann commented on a change in pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.

FlorianHockmann commented on a change in pull request #972: TINKERPOP-2067 Allow getting raw JToken data from Gremlin.Net.Driver.GremlinClient.
URL: https://github.com/apache/tinkerpop/pull/972#discussion_r228742759
 
 

 ##########
 File path: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs
 ##########
 @@ -68,6 +69,20 @@ public async Task ShouldHandleBigResponse()
             }
         }
 
+        [Fact]
+        public async Task ShouldHandle_JToken_Request()
+        {
+            var gremlinServer = new GremlinServer(TestHost, TestPort);
+            using (var gremlinClient = new GremlinClient(gremlinServer))
+            {
+                var gremlinScript = "'someString'";
+                
+                var response = await gremlinClient.SubmitWithSingleResultAsync<JToken>(gremlinScript);
+
+                Assert.NotNull(response);
 
 Review comment:
   Just a nit, but could you assert here that `"someString"` gets returned (like it's done in the `ShouldSendScriptForEvaluationAndReturnCorrectResult` test)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services