[GitHub] [ozone] symious commented on a diff in pull request #3683: HDDS-7126. Clean deletedBlock records of deleted containers

[GitBox <gi...@apache.org>]

symious commented on code in PR #3683:
URL: https://github.com/apache/ozone/pull/3683#discussion_r979330568


##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/block/TestDeletedBlockLog.java:
##########
@@ -527,6 +533,22 @@ public void testDeletedBlockTransactions()
     Assertions.assertEquals(2, blocks.size());
   }
 
+  @Test
+  public void testDeletedBlockTransactionsOfDeletedContainer()
+      throws IOException, TimeoutException {
+    int txNum = 10;
+    List<DeletedBlocksTransaction> blocks;
+
+    // Creates {TXNum} TX in the log.
+    Map<Long, List<Long>> deletedBlocks = generateData(txNum,

Review Comment:
   @swamirishi Thank you for the analysis, I added some comments in the PR instead of adding an integrated test. I tried to add the test earlier, but then I found the test is too time-costly, if we have too many tests for corner cases, the whole CI would become huge and long, so maybe a comment is enough here. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org