[jira] Commented: (OFBIZ-1573) Process order payment doesn't check for cancelled/rejected order (patch)

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559153#action_12559153 ] 

Jacques Le Roux commented on OFBIZ-1573:
----------------------------------------

I plenty agree : trunk rev.  612179  


> Process order payment doesn't check for cancelled/rejected order (patch)
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-1573
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1573
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: 1573-2.patch, 1573.patch
>
>
> The processOrderPayments service may approve or complete the order, but there is not check that the order is cancelled or rejected already.
> Currently calling the service for such an order would throw an error and roll back the transaction, but that cause other issues if the rest of the process is valid.
> There is a patch to check the order status, if the order is cancelled or rejected the service would have nothing to do so it would return success.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.