You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Tomoko Uchida (Jira)" <ji...@apache.org> on 2022/03/19 02:53:00 UTC
[jira] [Updated] (LUCENE-10475) Reconsider package structure in kuromoji and nori to mininize classes' visibiilty
[ https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tomoko Uchida updated LUCENE-10475:
-----------------------------------
Description:
Some internal dictionary classes in `.dict` package are exposed to public in order to share their constants with dictionary writers that are reside in a separate package `.util`.
`.util` actually has only dictionary writers/builders, it would make sense to merge all classes `.util` to `.dict` so that we can make the internals package-private.
The change was suggested/discussed in [https://github.com/apache/lucene/pull/740].
was:
Some internal dictionary classes in `.dict` package are exposed to public in order to share their constants with dictionary writers that are reside in a separate package `.util`.
`.util` actually has only dictionary writers/builders, it would make sense to merge all classes `.util` to `.dict` so that we can make the internals package-private.
The change was suggested/discussed in [https://github.com/apache/lucene/pull/740/commits/67ed0169733d3fcde47946f89dd6abac5fb31bce].
> Reconsider package structure in kuromoji and nori to mininize classes' visibiilty
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-10475
> URL: https://issues.apache.org/jira/browse/LUCENE-10475
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Tomoko Uchida
> Priority: Minor
>
> Some internal dictionary classes in `.dict` package are exposed to public in order to share their constants with dictionary writers that are reside in a separate package `.util`.
> `.util` actually has only dictionary writers/builders, it would make sense to merge all classes `.util` to `.dict` so that we can make the internals package-private.
> The change was suggested/discussed in [https://github.com/apache/lucene/pull/740].
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org