You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/03/17 14:50:57 UTC

[GitHub] [tomcat] F4ded opened a new pull request #483: Change the logic for judging whether a jsp file is outdated

F4ded opened a new pull request #483:
URL: https://github.com/apache/tomcat/pull/483


   Bug fix: after a jsp file is accessed, modify the jsp file to make it have a syntax error, when you accessing the jsp file again, the response will report a synatx error for the first time, but if it is accessed again within 4s(tomcat default config `modificationTestInterval`), you will get the reponse of the jsp file before modification.
   
   if a jsp file have a syntax error, its `JspServletWrapper` will carry a `compileException` which will be throw in `jspCompiler.compile()`, making `theServlet` can not reload. if you access the jsp file modified, tomcat will reset the `lastModificationTest` to the current system time. within 4s, tomcat will judge the jsp file with syntax errors as not outdated, then the request will be handled by the old jsp file's `theServlet`.
   
   before fixing:
   ![before](https://image-1302577725.cos.ap-beijing.myqcloud.com/uPic/before.gif)
   
   after fixing:
   ![after](https://image-1302577725.cos.ap-beijing.myqcloud.com/uPic/after.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] kkolinko commented on pull request #483: Change the logic for judging whether a jsp file is outdated

Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #483:
URL: https://github.com/apache/tomcat/pull/483#issuecomment-1071952012


   Duplicate of #484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] F4ded closed pull request #483: Change the logic for judging whether a jsp file is outdated

Posted by GitBox <gi...@apache.org>.
F4ded closed pull request #483:
URL: https://github.com/apache/tomcat/pull/483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] F4ded closed pull request #483: Change the logic for judging whether a jsp file is outdated

Posted by GitBox <gi...@apache.org>.
F4ded closed pull request #483:
URL: https://github.com/apache/tomcat/pull/483


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] kkolinko commented on pull request #483: Change the logic for judging whether a jsp file is outdated

Posted by GitBox <gi...@apache.org>.
kkolinko commented on pull request #483:
URL: https://github.com/apache/tomcat/pull/483#issuecomment-1071952012


   Duplicate of #484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org